Log shipping EE license check

Related to https://gitlab.com/gitlab-org/gitlab-ee/issues/2335

UDP log shipping should not work if the GitLab instance does not have an EE license.

Note this does not apply to GitLab.com groups as this is a server-wide setting

added license label

added Deliverable label

@mydigitalself As far as I can see, this is implemented in gitlab-omnibus, not gitlab-ee. I don't see how omnibus enforces that this is actually EE-only though. @marin Can you comment on that?

The fact that it's in gitlab-omnibus makes adding license checks a lot harder as it does not have access to the DB at reconfiguration time. This is related to https://gitlab.com/gitlab-org/omnibus-gitlab/issues/2442 (and https://gitlab.com/gitlab-org/gitlab-ee/issues/2850, kinda).

assigned to @rdavila

@mydigitalself This was EE only way before we had EES and EEP separation. We have no way of gating between EE types inside one package.

@marin do you think if having a copy of the license key in the file system can help with this type of check?

BTW, I'm asking the same here :)

@rdavila having a license on the filesystem has limited usability. You can see the investigation done in https://gitlab.com/gitlab-org/omnibus-gitlab/issues/2442 for more info :)

Thanks @marin, I understand all the pros and cons about this proposal now.

@mydigitalself looks like the only thing we can do here is showing some notification at the top of the page if this feature is configured and the current license doesn't allow its usage, am I right?

/cc @DouweM @marin @mydigitalself

To be perfectly honest, I don't know how we can license gate this or even print a message about it being enabled. The service is completely independent to the application and it is also running as a non-git user making it hard for application to know about it. We could think about a system where omnibus could place a file on reconfigure in a location GitLab has access to, but I don't know if this specific feature is worth the coding effort. @mydigitalself what do you think?

@marin @rdavila @mydigitalself If we cannot truly license gate this feature, would we be best off just moving it to CE?

I don't see why we would need to do a license check when this is in EE(S) package by default. I am fine either way, I am not sure how much this actually gets used.

@marin because we will be giving people EE by default and all CE features will work without a license. I agree this may not be that important a feature to be listed as EE only, will come back to you asap on it, apologies for the delay in responding, was on vacation last week and catching up.

@mydigitalself Should we still do something here for %9.5 ?

@DouweM sorry forgot to get back on this one, has been sitting in my Todos for a while.

So... I'm not even sure how I found this in the first place to put behind the check, perhaps someone has changed something since because...

1. We don't list it on https://about.gitlab.com/features/
2. We don't list it on https://about.gitlab.com/products/
3. https://docs.gitlab.com/omnibus/settings/logs.html is the only place it's now referenced with a banner that it's available in EEP

My suggestion would be to update the documentation to remove that note and make sure it's included in the CE omnibus package too - assuming it's currently not? cc @marin

I'm going to assign this to @marin since the next step is likely going to be on the omnibus side of things.

assigned to @marin

mentioned in merge request omnibus-gitlab!1829 (merged)

@mydigitalself @DouweM The change is in with omnibus-gitlab!1829 (merged)

unassigned @marin

@mydigitalself can we close this issue?

closed