No license warning is indiscernible from missing SSH key warning

Multiple flash containers seem to create some confusion as there is no clearly defined start and end of each container. We can probably find a simple CSS-only fix for this that will apply border-bottom or similar accordingly.

Steps to reproduce

1. Remove License from in your local EE setup
2. Remove SSH key also

Relevant Screenshot

added gitlab-ce~127616 ~19492 labels

What about adding some margin-bottom as well? /cc @dimitrieh

@nmrony @lbennett what about a white bottom-border? (this wont generally be visible, unless there are 2.. or make it so that it only is when there are 2?)

btw not a fan of it being possible showing 2 flash containers at once...

assigned to @nmrony

@dimitrieh Flash message is actually get replaced by new one. I think this here we got a notice. though I am not sure yet. Let me dig into it.

removed assignee

@dimitrieh, @mikegreiling already got this https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/8151 and like the idea a lot. Unassigning myself so that we can discuss on it.

@nmrony so this issue should be fixed by that one correct?

Not necessarily. My MR made it in almost two months ago, so the real question is why didn't it work in this case. Does it need to be fixed? What are the steps to reproduce this issue so I can investigate?

@mikegreiling Please remove license and ssh in your local EE. I also edited the issue description.

changed milestone to gitlab-ce%21

changed milestone to gitlab-ce%29

added gitlab-ce~17876 label

changed milestone to gitlab-ce%37

@annabeldunstone @jschatz1 what happened to this https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/8151 with

otherwise a simple white or #e5e5e5 border at the bottom can suffice i think ;)

added gitlab-ce2024186 and removed gitlab-ce2024184 labels

Might have something to do with different types of flash messages. cc @mikegreiling

changed title from Multiple flash containers are indiscernible to Multiple warning alerts are indiscernible

This is not about Flash messages but about .alert-warnings (I have adjusted the issue title).

The changes of https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/8151 require that .alert-warnings are wrapped in a .alert-wrapper—which the missing SSH key / license are not. They are inside a .flash-container.

It looks like my knowledge was outdated: https://gitlab.com/gitlab-org/gitlab-ce/blob/883488e0b2adda7dad93334f17f3895f05a7c587/app/views/layouts/_page.html.haml#L15-23 I'm looking into this now.

assigned to @winh

No GitLab Enterprise Edition license has been provided yet. is not even .alert-warning but a broadcast message: https://gitlab.com/gitlab-org/gitlab-ee/blob/master/app/views/layouts/_broadcast.html.haml#L1-4 The code is there since two years now so I am removing the gitlab-ce~17876 label.

removed gitlab-ce~17876 label

The license is also EE-only, so I moved the issue now.

changed title from Multiple warning alerts are indiscernible to No license warning is indiscernible from missing SSH key warning

@jschatz1 should we make this a UI polish and reschedule?

marked this issue as related to #11427