When MR approvals are disabled, but approvers were previously assigned, all approvers receive a notification on every MR

Summary

When MR approvals are disabled, but approvers were previously assigned, all approvers become participants and receive a notification on every MR.

Steps to reproduce

• Enable MR approvals

• Assign approvers

• Disable MR approvals

• Create a merge request

• All approvers show up as participants and receive notifications.

Example Project

https://gitlab.com/carmenbianca/mr-approval/merge_requests/1

I and @RipCazza are approvers in that project. MR approvals are disabled.

What is the current bug behavior?

Approvers become participants and receive notifications.

What is the expected correct behavior?

The feature is disabled, so approvers should not become participants and receive notifications.

Relevant logs and/or screenshots

N/A

Output of checks

N/A

Results of GitLab environment info

N/A

Results of GitLab application Check

N/A

Possible fixes

N/A

@carmenbianca Thanks for the report

/cc @vsizov

added Discussion ~238305 bug ~155976 reproduced on GitLab.com labels

assigned to @vsizov

WIP https://gitlab.com/gitlab-org/gitlab-ee/merge_requests/2647

mentioned in merge request !2647 (merged)

closed via merge request !2647 (merged)

@vsizov Thanks for fixing this so soon :)

mentioned in commit aa5fefc8

mentioned in issue #3395 (closed)

marked #3395 (closed) as a duplicate of this issue

changed milestone to %10.0

mentioned in commit 5c2892bf