Skip to content
GitLab
    • GitLab: the DevOps platform
    • Explore GitLab
    • Install GitLab
    • How GitLab compares
    • Get started
    • GitLab docs
    • GitLab Learn
  • Pricing
  • Talk to an expert
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
    • Switch to GitLab Next
    Projects Groups Topics Snippets
  • Register
  • Sign in
  • GitLab GitLab
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributor statistics
    • Graph
    • Compare revisions
    • Locked files
  • Issues 9,362
    • Issues 9,362
    • List
    • Boards
    • Service Desk
    • Milestones
    • Iterations
    • Requirements
  • Jira
    • Jira
  • Merge requests 139
    • Merge requests 139
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Artifacts
    • Schedules
    • Test cases
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Container Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Code review
    • Insights
    • Issue
    • Repository
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar

Do not update/delete: Banner broadcast message test data

Do not update/delete: Notification broadcast message test data

  • GitLab.orgGitLab.org
  • GitLabGitLab
  • Issues
  • #3104
Closed
Open
Issue created Aug 06, 2017 by username-removed-96420@carmenbianca

When MR approvals are disabled, but approvers were previously assigned, all approvers receive a notification on every MR

Summary

When MR approvals are disabled, but approvers were previously assigned, all approvers become participants and receive a notification on every MR.

Steps to reproduce

  • Enable MR approvals

  • Assign approvers

  • Disable MR approvals

  • Create a merge request

  • All approvers show up as participants and receive notifications.

Example Project

https://gitlab.com/carmenbianca/mr-approval/merge_requests/1

I and @RipCazza are approvers in that project. MR approvals are disabled.

What is the current bug behavior?

Approvers become participants and receive notifications.

What is the expected correct behavior?

The feature is disabled, so approvers should not become participants and receive notifications.

Relevant logs and/or screenshots

N/A

Output of checks

N/A

Results of GitLab environment info

N/A

Results of GitLab application Check

N/A

Possible fixes

N/A

Assignee
Assign to
Time tracking