From Validation error: Validate approvals before merge Number... when Approvers is a group
Summary
On the gitlab.com website.
This project is forked, is in danteinc/ouli subgroup, approvers and approvals required comes from project settings.
I can create a merge request where the approvals required
is set to 1. The approvers
are a group: danteinc-ouli. Then I attempt to edit the merge request (ex: add WIP: to the title) and I get the error
"The form contains the following error: Validate approvals before merge Number of approvals must be greater than those on target project"
even though it let me create it with the same settings.
Steps to reproduce
- Create a merge request that has 1
Approvals required
and add a group to theApprovers
list - Edit the merge request and hit save
- Form is rejected with the above validation message
What is the current bug behavior?
Form displays the above validation error
What is the expected correct behavior?
Form should submit successfully
Relevant logs and/or screenshots
Project Settings
Validation Error
Merge request approval settings
Output of checks
This bug happens on GitLab.com
Possible fixes
Logic might be comparing the list count to the Approvals required
number and not counting how many members are in the group. Not sure why the same validation message doesn't come up when creating the merge request.
Workaround
If you set the approvals required to 0 it lets you hit save, and when you go to edit the MR again Approvals required
is still set at 1