Unable to click on "Mirror repository" button in 9.5 RC1

Steps to reproduce:

1. Click on New Project
2. Click on "Repo by URL"
3. Enter in https://github.com/jneen/rouge.git in the URL

The "Mirror repository" button remains disabled.

This may be due to f44bea37.

/cc: @filipa

changed the description

added frontend label

@stanhu the disabled property was already there: https://gitlab.com/gitlab-org/gitlab-ee/commit/f44bea378675e4d5227fa528f3dca641ae0ec950#41cda6f4f00ee29dea22932e22aaaa631b3fa1aa_27_24

those changes are only style

@nick.thomas do you know what could be? Should the disabled be removed?

@DouweM and I noticed this while testing the pull mirroring with SSH keys feature, which was before f44bea37

History suggests the disabled: true was added in 0774b69f

@eReGeBe do you remember the logic?

It looks like there is meant to be JS that removes the disabled: true property when text is added to the import URL.

Presumably this was removed at some point when taking out inline JS (in CE, maybe?) without replicating the functionality.

This https://gitlab.com/gitlab-org/gitlab-ee/commit/0774b69f1c4ae9f49e622e4681c23c84ab8a00d6#accca7705fc631c907c147486e05462a29c670c1_142_142 needs to be ported into https://gitlab.com/gitlab-org/gitlab-ee/blob/master/app/assets/javascripts/projects/project_new.js

By the looks of it, setting mirror_user via the ProjectsController#create action is also broken (the hidden_field at the bottom). It needs to follow similar logic to that found in Projects::MirrorController#update.

I'll create an issue for that. We can get rid of the hidden_field entirely, TBH.

We actually go through Projects::ImportsController#create which has all this.

@nick.thomas please ping me on Slack if you need me ;)

Right, I was thinking this was a frontend issue with some JavaScript not enabling the button: https://gitlab.com/gitlab-org/gitlab-ee/issues/3146#note_37344203

/cc: @timzallmann

I can't reproduce this on .com.

.com isn't running RC1 at the moment. You have to install RC1 separately or use the 9-5-stable-ee branch.

Going to put the JS back, will find the original commit.

assigned to @filipa

Ah! Found it!

@stanhu the mirror checkbox has a disabled attribute that was added in this commit: https://gitlab.com/gitlab-org/gitlab-ee/commit/0774b69f1c4ae9f49e622e4681c23c84ab8a00d6, along with JS to enable it.

It was lost in here: https://gitlab.com/gitlab-org/gitlab-ee/commit/c4dc7e843012e5c84ca68d512fb08e2723fefb81

Opening an MR to add it back

mentioned in merge request !2670 (merged)

@filipa Good find!

Thanks @filipa good find.

closed via merge request !2670 (merged)

mentioned in commit d8736b89

mentioned in commit e37f8973

mentioned in issue #3233 (closed)

marked this issue as related to #3233 (closed)