Warning noise when `geo_nodes` table does not exist

This warning pops up whenever the geo_nodes table does not exist:

$ sudo gitlab-rake gitlab:backup:restore BACKUP=1504562288_2017_09_04_9.5.3-ee
WARNING: Unable to check/update clone_url_prefix for Geo: PG::UndefinedTable: ERROR:  relation "geo_nodes" does not exist
LINE 5:                WHERE a.attrelid = '"geo_nodes"'::regclass
                                          ^
:               SELECT a.attname, format_type(a.atttypid, a.atttypmod),
                     pg_get_expr(d.adbin, d.adrelid), a.attnotnull, a.atttypid, a.atttypmod
                FROM pg_attribute a LEFT JOIN pg_attrdef d
                  ON a.attrelid = d.adrelid AND a.attnum = d.adnum
               WHERE a.attrelid = '"geo_nodes"'::regclass
                 AND a.attnum > 0 AND NOT a.attisdropped
               ORDER BY a.attnum
Unpacking backup ... done
Before restoring the database we recommend removing all existing
tables to avoid future upgrade problems. Be aware that if you have
custom tables in the GitLab database these tables and all data will be
removed.

I think we should suppress the debug output if the table doesn't exist.

@stanhu Should also make sense to check if the Geo feature is available first on the Geo initializer?

@dbalexandre Yes, that makes sense.

Had the same issue when running geo migrations on my secondary

> bundle exec rake geo:db:migrate

WARNING: Unable to check/update clone_url_prefix for Geo: PG::UndefinedTable: ERROR:  relation "geo_nodes" does not exist
LINE 5:                WHERE a.attrelid = '"geo_nodes"'::regclass
                                          ^
:               SELECT a.attname, format_type(a.atttypid, a.atttypmod),
                     pg_get_expr(d.adbin, d.adrelid), a.attnotnull, a.atttypid, a.atttypmod
                FROM pg_attribute a LEFT JOIN pg_attrdef d
                  ON a.attrelid = d.adrelid AND a.attnum = d.adnum
               WHERE a.attrelid = '"geo_nodes"'::regclass
                 AND a.attnum > 0 AND NOT a.attisdropped
               ORDER BY a.attnum

added bug label

I wonder if this will be resolved by https://gitlab.com/gitlab-org/gitlab-ee/merge_requests/3019

/cc @to1ne

!3019 (merged) resolves this noise for bundle exec rake geo:db:migrate on a secondary. Although the original issue (probably) still exists.

@dbalexandre did you mean to post this comment on this issue instead?

@nick.thomas @to1ne Should not this bug related to https://gitlab.com/gitlab-org/gitlab-ee/blob/master/config/initializers/geo.rb#L8?

Maybe the proper fix should be something like:

if File.exist?(Rails.root.join('config/database_geo.yml'))
  Rails.application.configure do
    config.geo_database = config_for(:database_geo)
  end
else
  begin
    if Gitlab::Geo.primary?
      Gitlab::Geo.current_node&.update_clone_url!
    end
  rescue => e
    warn "WARNING: Unable to check/update clone_url_prefix for Geo: #{e}"
  end
end