Disabling MR approvals still includes approvers as participants

Summary

(Summarize the bug encountered concisely)

Steps to reproduce

• Create a new group, GroupA
• Assign a couple of users there
• Create a new project, ProjectX
• Create a new Merge Request in ProjectX
• Notice that only the Author is a particpant
• Enable Merge Request approvals in the Project Settings
• Assign GroupA as an "Approver Group"
• Create a new Merge Request in ProjectX
• Notice that the members of GroupA are added as participants (approvers)
• Disable Merge Request approvals again
• Create a new Merge Request in ProjectX
• Notice that the members of GroupA are added as participants (approvers)

Example Project

https://gitlab.com/issue-reproduce/disable-approvals

What is the current bug behavior?

All of the approver group members are added to the Merge Request as participants regardless of the Merge Request approval setting status for the project

What is the expected correct behavior?

No approvers should be added as participants on the Merge Request whilst Merge Request approvals are disabled

Relevant logs and/or screenshots

Output of checks

(If you are reporting a bug on GitLab.com, write: This bug happens on GitLab.com)

Results of GitLab environment info

reproduced on GitLab.com v9.5.4-ee

Results of GitLab application Check

reproduced on GitLab.com v9.5.4-ee

Possible fixes

(If you can, link to the line of code that might be responsible for the problem)

/cc @vsizov

It has been fixed in https://gitlab.com/gitlab-org/gitlab-ee/merge_requests/2647 and the issue is duplicate of https://gitlab.com/gitlab-org/gitlab-ee/issues/3104

The fix will be available for 10.0

@vsizov Ah, thanks I forgot about that issue.

Closing this one down as a duplicate

marked this issue as a duplicate of #3104 (closed)

closed