Investigate return code of job artifacts API

Failing build during CE-to-EE merge: https://gitlab.com/gitlab-org/gitlab-ee/-/jobs/32221973

We changed the spec to expect 404, but @grzesiek needs to investigate if this is indeed the now-correct status code.

On a related note, if we extracted the API implementation to job_artifacts.rb, the spec probably should have moved with it.

mentioned in commit 73be4baf

assigned to @grzesiek

Thanks for fixing it and creating the issue! I will create a new MR that fixes tests and verify status codes!

mentioned in commit 2674a96f

I believe that correct status code is a new one - 404. In the test, project is a private one, so returning 401 would leak existence of it. Previously we required authentication, but we decided to allow unauthenticated requests to be processed, so, in my opinion, correct status code is now 404.

The reason why this failure was present in EE, is that we have additional tests for object storage in EE. I didn't investigate the EE compatibility check failure, so it is my fault that this there was no EE equivalent of the original MR. Sorry!

Let's close this issue and add a note about moving some specs to job_artifacts_spec.rb to https://gitlab.com/gitlab-org/gitlab-ee/issues/3378.

Closing in favor of https://gitlab.com/gitlab-org/gitlab-ee/issues/3378.

closed