Init script is broken

# /etc/init.d/gitlab restart
/etc/init.d/gitlab: line 110: syntax error near unexpected token `do'
/etc/init.d/gitlab: line 110: `  while [ ! -f $web_server_pid_path ] || [ ! -f $sidekiq_pid_path ] || [ ! -f $gitlab_            workhorse_pid_path ] || { [ "$mail_room_enabled" = true ] && [ ! -f $mail_room_pid_path ] || { [ "$gitlab_pages_enabl            ed" = true ] && [ ! -f $gitlab_pages_pid_path ]; }; do'

The error has been introduced in 3504b68a, there is an extra { in line 110.

It needs an extra closing bracket (and semicolon), like so:

$ git diff lib/support/init.d/gitlab
diff --git a/lib/support/init.d/gitlab b/lib/support/init.d/gitlab
index 2b2a5fb..79f5b8e 100755
--- a/lib/support/init.d/gitlab
+++ b/lib/support/init.d/gitlab
@@ -107,7 +107,7 @@ check_pids(){
 wait_for_pids(){
   # We are sleeping a bit here mostly because sidekiq is slow at writing its pid
   i=0;
-  while [ ! -f $web_server_pid_path ] || [ ! -f $sidekiq_pid_path ] || [ ! -f $gitlab_workhorse_pid_path ] || { [ "$mail_room_enabled" = true ] && [ ! -f $mail_room_pid_path ] || { [ "$gitlab_pages_enabled" = true ] && [ ! -f $gitlab_pages_pid_path ]; }; do
+  while [ ! -f $web_server_pid_path ] || [ ! -f $sidekiq_pid_path ] || [ ! -f $gitlab_workhorse_pid_path ] || { [ "$mail_room_enabled" = true ] && [ ! -f $mail_room_pid_path ]; } || { [ "$gitlab_pages_enabled" = true ] && [ ! -f $gitlab_pages_pid_path ]; }; do
     sleep 0.1;
     i=$((i+1))
     if [ $((i%10)) = 0 ]; then

There's a pending merge request at https://gitlab.com/gitlab-org/gitlab-ee/merge_requests/223. It will be in a patch release. But you can also fix your instance now.

!223 (merged) was merged. Closing this one.

Status changed to closed

mentioned in commit 344d6e6f

mentioned in commit 93c786f6