Skip to content

Repository size limit checks fails badly with a merge commit

The repository size limit scans for deltas but assumes the new file will point to OIDs as Git::Blob objects. However, it's possible you may get a Rugged::Commit pointer instead. Still not quite sure how, but it looks like it's happening for the customer.

ZD: https://gitlab.zendesk.com/agent/tickets/82217

NoMethodError (undefined method `size' for #<Rugged::Commit:0x007f9333d2e560>):
  /opt/gitlab/embedded/service/gitlab-rails/lib/gitlab/git/blob.rb:94:in `block in raw'
  /opt/gitlab/embedded/service/gitlab-rails/lib/gitlab/gitaly_client.rb:95:in `block in migrate'
  /opt/gitlab/embedded/service/gitlab-rails/lib/gitlab/metrics/influx_db.rb:92:in `measure'
  /opt/gitlab/embedded/service/gitlab-rails/lib/gitlab/gitaly_client.rb:94:in `migrate'
  /opt/gitlab/embedded/service/gitlab-rails/lib/gitlab/git/blob.rb:86:in `raw'
  /opt/gitlab/embedded/service/gitlab-rails/lib/ee/gitlab/deltas.rb:13:in `block in delta_size_check'
  /opt/gitlab/embedded/service/gitlab-rails/lib/ee/gitlab/deltas.rb:12:in `each_delta'
  /opt/gitlab/embedded/service/gitlab-rails/lib/ee/gitlab/deltas.rb:12:in `delta_size_check'
  /opt/gitlab/embedded/service/gitlab-rails/lib/gitlab/git_access.rb:218:in `block in check_change_access!'
  /opt/gitlab/embedded/service/gitlab-rails/lib/gitlab/changes_list.rb:12:in `each'
  /opt/gitlab/embedded/service/gitlab-rails/lib/gitlab/changes_list.rb:12:in `each'
  /opt/gitlab/embedded/service/gitlab-rails/lib/gitlab/git_access.rb:212:in `check_change_access!'
  /opt/gitlab/embedded/service/gitlab-rails/lib/gitlab/git_access.rb:191:in `check_push_access!'
  /opt/gitlab/embedded/service/gitlab-rails/lib/gitlab/git_access.rb:53:in `check'
  /opt/gitlab/embedded/service/gitlab-rails/lib/api/internal.rb:40:in `block (2 levels) in <class:Internal>'
  /opt/gitlab/embedded/lib/ruby/gems/2.3.0/gems/grape-0.19.1/lib/grape/endpoint.rb:59:in `call'
  /opt/gitlab/embedded/lib/ruby/gems/2.3.0/gems/grape-0.19.1/lib/grape/endpoint.rb:59:in `block (2 levels) in generate_api_method'
  /opt/gitlab/embedded/lib/ruby/gems/2.3.0/gems/activesupport-4.2.8/lib/active_support/notifications.rb:1
Edited by Stan Hu