“Service Desk” is visible for non project-members

Summary

Non project members can see the “Service desk” tab on a project and even the “Turn on Service Desk” button although the functionality is disabled.

Steps to reproduce

Create an internal project. Register a new user account and access the project. Open the “Issues → Service Desk” section.

Example Project

https://gitlab.com/fusonic/fcp/fcp/issues/service_desk

What is the current bug behavior?

Section is visible.

What is the expected correct behavior?

If Service Desk is disabled, the section should only be visible for people who have permission to enable it.

changed milestone to %10.0

added Discussion regression ~1790368 labels

/cc: @victorwu, @felipe_artur

added Next Patch Release label

This is intended behavior. The Service Desk section is for all users to see. Because all users can be made aware of the feature and see the UI. Non-project members cannot turn on Service Desk because they cannot access the project settings. (So this is analogous to if you are signed out of GitLab but you still see the new issue button. If you click it, you can't create a new issue.)

closed

OK, that's not really logical to me.

Why should a user/guest see features that I as a project maintainer chose not to use? How is it useful for a user to see the “Turn on Service Desk” button even if he is not allowed to make this decision?

@victorwu Is it ok to show the section even if it is disabled in project settings?

If it is we should probably hide the Activate Service Desk button from people which does not have the right permissions. It throws a 404 anyway.

changed milestone to %9.5

removed milestone

@felipe_artur : Which button are you referring to. The button when on the service desk page itself? That's the Turn on Service Desk button here right?

I think you might be right and I was confused with being logged out. That button goes to the project settings screen. I think we should only show that button if the user is logged in and has permission to access the project settings. Is that what you are saying?

@victorwu Yes.

Thanks @felipe_artur . I created this to address that separately: https://gitlab.com/gitlab-org/gitlab-ee/issues/3509

mentioned in commit 0ece3d65