Hide `Turn on Service Desk` button if you don't have permissions to configure Service Desk

• The Service Desk menu item in the sidebar and the dedicated page should always be shown, as long as the correct license (EEP) or plan is configured.
• This is regardless of whether Service Desk has been configured on or off in the project settings.
• However, if the current user does not have permissions to configure the project settings, then they shouldn't see the Turn on Service Desk button. (Because clicking it does nothing for them.)
• This is both in the empty state area and in the instructional area.

changed milestone to %10.0

added Discussion regression ~1790368 labels

changed the description

@brycepj : Does this make sense? I'm not sure discussed this scenario specifically. Or maybe we did but I didn't understand it. My fault.

• We should always show the service desk UI (nav and actual page) provided the license is EEP.
• But if SD is configured off and the user has no permissions to configure it on, then don't show the button that takes them to the project settings. So it's two more boxes in https://gitlab.com/gitlab-org/gitlab-ee/issues/3049.

This make sense?

mentioned in issue #3476 (closed)

@brycepj @felipe_artur : And I think we should show this nav UI and the dedicated page even if reply by email config is not on. See my comment here: https://gitlab.com/gitlab-org/gitlab-ee/issues/3495#note_40989955.

So the flow is:

• You always see "Service Desk" in the nav and the dedicated page as long as you have EEP.
• You have permissions to turn on SD, so you turn it on by clicking the button. If you don't have permissions, maybe we should have some text copy telling you that you need to be a project admin.
• As an admin, you click the button and are navigated to the project settings.
• In the project settings, there is some text copy to say that you also need to set up reply-by-email to use this feature (https://gitlab.com/gitlab-org/gitlab-ee/issues/3495#note_40989955).
• So you do that, and now you can turn on SD.

@victorwu Yep, these changes sound like a good idea to me, and wouldn't be too difficult.

Thanks @brycepj : I think we should fix this one as a regression since the button currently results in 404 if you don't have the correct permissions, right?

This other one can be a separate issue: https://gitlab.com/gitlab-org/gitlab-ee/issues/3495.

assigned to @brycepj

mentioned in merge request !3020 (merged)

closed via merge request !3020 (merged)

mentioned in commit 2806fe10