Regression: LDAP group synchronization is broken for our company's LDAP with GitLab 8.6

About one year ago I made the following change 37499d87 to get the LDAP group synchronization working with our company's LDAP. This was removed by a refactoring with commit 3f0c8ea9. So after the update to the latest version of GitLab the whole group synchronization is gone and nobody was able to push its changes to any repository. To fix this the group synchronization must check also if the member attribute contains the following value: uid=<username>

Added ldap label

Milestone changed to 8.7

Reassigned to @dblessing

Hi @1and1_ebusiness Thanks for linking to the old commit. I'll take a look at this and get it fixed asap.

mentioned in merge request !335 (merged)

Hi @1and1_ebusiness There's a pending fix in https://gitlab.com/gitlab-org/gitlab-ee/merge_requests/335. It has nice tests to prevent this regression again. If accepted, it will make it in to 8.6.6 sometime this week or next.

Status changed to closed by commit c7b7510b

mentioned in commit c7b7510b

Milestone changed to 8.6

Added regression label

mentioned in commit b7727b88

Mentioned in commit c7b7510b