Git hooks don't fire when committing from the UI

Summary

Git hooks no longer fire when committing from the web UI

Steps to reproduce

1. Add a commit message hook to a project. For example, try foo.*.
2. Then, try to commit a file in the UI with a commit message like test.
3. Observe that the file is committed successfully.

Expected behavior

On 8.6 and earlier, these same steps produced a pre-receive hook error.

cc/ @DouweM

Added hooks regression and removed webhooks labels

Reassigned to @rdavila

mentioned in merge request !412 (closed)

Reassigned to @jameslopez

mentioned in issue #497 (closed)

see also my comment here https://gitlab.com/gitlab-org/gitlab-ee/issues/279#note_3783022

@vsizov remember to close this one as well ;)

@jameslopez @vsizov I think there's a lot of conversation from chat that is missed in this and other issues. Can one of you please summarize? What has been done? Is this fixed or what is the outcome of conversations?

I think this will fix the issue - see the comments: https://gitlab.com/gitlab-org/gitlab-ee/merge_requests/281/diffs#note_12600583

The original fix and this one are a bit of a workaround though. I remember going for the boring solution instead of https://gitlab.com/gitlab-org/gitlab-ee/issues/429 that should also fix both problems.

mentioned in merge request !487 (merged)

fix is here https://gitlab.com/gitlab-org/gitlab-ee/merge_requests/487

Status changed to closed by merge request !487 (merged)

mentioned in commit d47fe868

mentioned in commit b138357b

Mentioned in commit d47fe868