Skip to content
GitLab
    • GitLab: the DevOps platform
    • Explore GitLab
    • Install GitLab
    • How GitLab compares
    • Get started
    • GitLab docs
    • GitLab Learn
  • Pricing
  • Talk to an expert
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
    • Switch to GitLab Next
    Projects Groups Topics Snippets
  • Register
  • Sign in
  • GitLab GitLab
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributor statistics
    • Graph
    • Compare revisions
    • Locked files
  • Issues 9,362
    • Issues 9,362
    • List
    • Boards
    • Service Desk
    • Milestones
    • Iterations
    • Requirements
  • Jira
    • Jira
  • Merge requests 139
    • Merge requests 139
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Artifacts
    • Schedules
    • Test cases
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Container Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Code review
    • Insights
    • Issue
    • Repository
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar

Do not update/delete: Banner broadcast message test data

Do not update/delete: Notification broadcast message test data

  • GitLab.orgGitLab.org
  • GitLabGitLab
  • Issues
  • #67
Closed
Open
Issue created Nov 06, 2015 by Drew Blessing@dblessingMaintainer

Cannot accept a merge request when using JIRA if issue closing pattern is used

Currently, if JIRA integration is enabled and a user includes the issue closing pattern in a merge request description or a commit that is part of a merge request, the merge request cannot be accepted. An error is thrown and the merge request tries to merge indefinitely until the page is reloaded.

After some debugging I found that the reason for this is because the JIRA service currently only expects a Commit object to be sent when services are executed. However, in the case described above the service is executed and receives the MergeRequest object. This does not happen if a user uses the issue closing pattern in a commit and pushes directly to the default branch. In this case the GitPushService passes a Commit object and all is well.

This issue was already fixed in !45 (merged) but due to merge conflicts cannot be picked directly in to 8-1-stable-ee for a patch. I think the best bet is to pull the bare minimum out of !45 (merged) to make this work with both objects.

I discovered this myself while testing JIRA integration for https://gitlab.zendesk.com/agent/tickets/11034. Then, another customer reported exactly this issue in https://gitlab.zendesk.com/agent/tickets/11214

Assignee
Assign to
Time tracking