Comment on pictures inside a comment (design discussions)
original comment/issue https://gitlab.com/gitlab-org/gitlab-ce/issues/2641#note_18302491
first do commenting on a picture diff https://gitlab.com/gitlab-org/gitlab-ee/issues/1768
As the other section is taken care of we now can focus on the other side of this issue, which is probably even more important! This is the part which is really important to design driven discussion, which generally happens only in issues.
IMO we should not think about this the same way as code. We are handling visual information and as @brycepj explained.. a lot of versions (if we'd think about it the same way as code) would make it hard to compare or point out exactly which change we are discussing.
My plan is as follows:
- Reuse the sub discussions UI from Merge Requests
It has the added benefit to be able to be resolved and it allows for focused discussion.
- 1 file focused sub discussion or 2 files user invoked mini diff discussion
A user will be able to select 1 or 2 images from the previous discussions. From it they will be able to invoke a sub discussion, which will behave similarly to the pictures inside a commit example and look like:
It will of course feature the same collapsed/expanded functionality. Plus if 2 images are selected it will be a diff with 2-up/swipe/onion skin available:
Now we come to the part that is still kind of fuzzy. How will a user be able to select images, in order to start a discussion from them? An option would be a media tab in the issue discussion:
The media tab will serve as a mini repository for an issue discussion. Making it possible to upload images and only afterwards begin a diff sub discussion on them.
However, we could also just be able to select these sort of images from the discussion thread itself.. The way I envisioned it is that you would have a similar functionality to review products in web stores like this.
That could look like:
When clicking the button, we would got to our newly created sub discussion inside the general issue discussion.. there we will be able to comment.
If a sub discussion is started but no comment is put in, it will be deleted.. as if it never was.
As the original issue is a moonshots in GitLab FOSS , i think this one is in the same range!
cc: @tauriedavis @hazelyang @pedroms @cperessini @awhildy @dzaporozhets @JobV
Activity
Mentioned in issue gitlab-foss#2641 (closed)
moved from https://gitlab.com/gitlab-org/gitlab-ce/issues/2641#note_18302765
In my discussion with @awhildy we came to the conclusion that pictures inside a commit https://gitlab.com/gitlab-org/gitlab-ce/issues/2641#note_18255217 is pretty solid.
However pictures inside a comment https://gitlab.com/gitlab-org/gitlab-ce/issues/2641#note_18302491 will need a little bit more thought.
Points of discussion were:
- Does the "2-up/swipe/onion skin" functionality make much sense in issue/design discussion as opposed to commit discussion, which is about implementation details.
- We actually want to be able to start focused discussions on more than 2 images inside an issue! (For example, lets discuss these 3 designs next to each other)
I agree with these 2 things!
Edited by Dimitrie Hoekstra-
points from UX meeting:
- Improve upon the current image previews alongside of this, basically refering to https://gitlab.com/gitlab-org/gitlab-ce/issues/2641#note_16910562
- Improve upon the current image previews alongside of this, basically refering to https://gitlab.com/gitlab-org/gitlab-ce/issues/2641#note_16910562
-
@awhildy get this to backlog as well?
Milestone changed to %Backlog in gitlab-foss
Mentioned in issue gitlab-foss#23547 (moved)
Mentioned in issue gitlab-foss#24788 (moved)
You said the media tab could be helpful. Do you want it even if we also have the more advanced design?
I see it being super useful since designers can quickly see all images (even video and audio?) in one place easily.
So if you think this is desired regardless of the final design, let's build it first. It would be our first feature, should be relatively straighforward to build, and would add value on its own.
CC @awhildy
-
@victorwu what is this advanced design you speak of ? :)
As for if we really need this? I think this still needs more discussion. Also this will have various implication on the backend side of stuff.. As currently all discussion images are just uploaded to one big container I imagine. This change would create the need for an actual images storage management solution which is tied to discussions.
If we decide we would need it, it shouldn't live on its own.. it would need additional functionality to begin with, even without the comments on images... something like pinning the latest design images.. etc
but yes the complete picture of this issue will be insanely useful for how we use GitLab
@dimitrieh : Okay that makes sense. Looks like you want more discussion from the design team regarding this before making any even small iterations. Gotcha. I'll comment on the other issue in that comment thread.
Mentioned in issue gitlab-foss#19055 (closed)
Added code review in GitLab FOSS label
@victorwu: We brainstormed about this issue with @dzaporozhets @cperessini @tauriedavis @pedroms @sarahod @dimitrieh @awhildy at the 2017 GitLab summit. Rough notes can be found here: https://drive.google.com/drive/folders/0B-PqsmU0p5QVNTNwb3VDU0RMM2M?usp=sharing
We discussed how we could break down this effort into a number of small steps.
- If this is a helpful stepping stone from a technical perspective, we could start with the ability to have a resolvable discussion on images that are submitted as part of an MR (images as assets as described here https://gitlab.com/gitlab-org/gitlab-ce/issues/2641).
- Next, add the ability to start a resolvable discussion when you hover on an image (or images) that are in a comment. This should be true for images in comments on both issues and MRs.
- Then consider additional features such as being able to add callouts with comments to specific parts of the images (circled numbers), and the ability to star specific images, or resolve the discussion by selecting one or more images as the agreed upon design.
Let me know if this makes sense and/or any thoughts/ideas/feedback you might have. Thanks!
Great @awhildy . That sounds good. Nothing from me at the moment.
-
thanks @awhildy i was just looking for those notes!
mentioned in issue gitlab-foss#27357 (closed)
mentioned in issue gitlab-foss#27647 (moved)
mentioned in issue gitlab-foss#30299 (moved)
changed milestone to %Backlog in gitlab-foss
changed milestone to %Next 3-6 months in gitlab-foss
mentioned in issue gitlab-foss#33665 (moved)
moved from gitlab-foss#24816 (moved)
){kind=link}
