No commit-data loaded if branch contains a slash
Summary
If the viewed branch contains a slash in it's name gitlab fails while loading the commit-data from /{user}/{project}/refs/{branch}/logs_tree
Steps to reproduce
- create a branch with an slash inside e.g.
foo/bar - visit
/{user}/{project}/tree/foo/bar(note that the slash offoo/barhas to be unescaped here in branch, if it is escaped we got a 404-page – maybe another ticket) -
Loading commit data… will load forever because the JS requested
/{user}/{project}/tree/foo%2Fbarinstead of the working/{user}/{project}/tree/foo/bar
Expected behavior
/{user}/{project}/tree/foo%2Fbar would answer with 200-status and commit-data and Loading commit data… would be replaced by the concrete received commit-data
Actual behavior
/{user}/{project}/tree/foo%2Fbar fails with 404-status and Loading commit data… remains forever
Relevant logs and/or screenshots
Possible fixes
This problem was already fixed but was opened again by some other issues. gitlab-com/support-forum#952 (closed) and gitlab-foss#21106 (closed)
I'm not familiar with ruby but I'm totally sure that your fixes at extracts_path.rb were at least partly wrong at all and the source of all of these issues are on other positions. I think the problem is much more regarding to the initialisation of @logs_path or it's use in the templates. Unfortunately I have no time to learn ruby nor fixing these simple bugs on my own, but the problem is definitely more abstract than the previous fixings.
Activity
Hi @nemoinho89 Thank for raising an issue. Please could you provide some more information about the environment where you have noticed the problem:
Please mention if you are seeing the issue on GitLab.com. If seeing the issue on your own hosted GitLab instance, please provide the following information:
- Run a diagnostic check of GitLab and it's components:
sudo gitlab-rake gitlab:check- Gather GitLab specific environment information:
sudo gitlab-rake gitlab:env:infoI can't see the same issue at gitlab.com so it works slow but stable (e.g. feature/add-pipeline-unlock-worker).
So, the output is the following:
gitlab-rake gitlab:check
Checking GitLab Shell ... GitLab Shell version >= 3.6.6 ? ... OK (3.6.6) Repo base directory exists? default... yes Repo storage directories are symlinks? default... no Repo paths owned by git:git? default... no User id for git: 998. Groupd id for git: 998 Try fixing it: sudo chown -R git:git /var/opt/gitlab/git-data/repositories For more information see: doc/install/installation.md in section "GitLab Shell" Please fix the error above and rerun the checks. Repo paths access is drwxrws---? default... yes hooks directories in repos are links: ... ████████████ / gitlab-testing ... ok Running /opt/gitlab/embedded/service/gitlab-shell/bin/check Check GitLab API access: OK Access to /var/opt/gitlab/.ssh/authorized_keys: OK Send ping to redis server: OK gitlab-shell self-check successful Checking GitLab Shell ... Finished Checking Sidekiq ... Running? ... yes Number of Sidekiq processes ... 1 Checking Sidekiq ... Finished Checking Reply by email ... Reply by email is disabled in config/gitlab.yml Checking Reply by email ... Finished Checking LDAP ... LDAP is disabled in config/gitlab.yml Checking LDAP ... Finished Checking GitLab ... Git configured with autocrlf=input? ... yes Database config exists? ... yes All migrations up? ... yes Database contains orphaned GroupMembers? ... no GitLab config exists? ... yes GitLab config outdated? ... no Log directory writable? ... yes Tmp directory writable? ... yes Uploads directory setup correctly? ... no Try fixing it: sudo chown -R git /var/opt/gitlab/gitlab-rails/uploads sudo find /var/opt/gitlab/gitlab-rails/uploads -type f -exec chmod 0644 {} \; sudo find /var/opt/gitlab/gitlab-rails/uploads -type d -not -path /var/opt/gitlab/gitlab-rails/uploads -exec chmod 0700 {} \; For more information see: doc/install/installation.md in section "GitLab" Please fix the error above and rerun the checks. Init script exists? ... skipped (omnibus-gitlab has no init script) Init script up-to-date? ... skipped (omnibus-gitlab has no init script) projects have namespace: ... ████████████ / gitlab-testing ... yes Redis version >= 2.8.0? ... yes Ruby version >= 2.1.0 ? ... yes (2.3.1) Your git bin path is "/opt/gitlab/embedded/bin/git" Git version >= 2.7.3 ? ... yes (2.7.4) Active users: 5 Checking GitLab … Finishedand furthermore
gitlab-rake gitlab:env:info
System information System: Debian 7.9 Current User: git Using RVM: no Ruby Version: 2.3.1p112 Gem Version: 2.6.6 Bundler Version:1.13.6 Rake Version: 10.5.0 Sidekiq Version:4.2.1 GitLab information Version: 8.13.5 Revision: 09cedb5 Directory: /opt/gitlab/embedded/service/gitlab-rails DB Adapter: postgresql URL: http://git.████████.com HTTP Clone URL: http://git.████████.com/some-group/some-project.git SSH Clone URL: git@git.████████.com:some-group/some-project.git Using LDAP: no Using Omniauth: no GitLab Shell Version: 3.6.6 Repository storage paths: - default: /var/opt/gitlab/git-data/repositories Hooks: /opt/gitlab/embedded/service/gitlab-shell/hooks/ Git: /opt/gitlab/embedded/bin/git-
@nemoinho89 Thanks for the extra info. Have you changed the configuration of GitLab at all? Are you using the bundled NGINX web server and standard config?
I see this issue in a private deployment of gitlab-ce 8.16.4.
If you reproduce the request to
/ref/:branch/logs_treereplacing the %2F occurrences with actual slashes, it succeeds. (I used Chrome's "Copy as cURL" to obtain all the necessary headers)Maybe the branch_name string used for building the route is incorrectly escaped? Is there something like
String#html_safefor route params?In the same gitlab-ce instance, tree urls in
/:group/:project/branchesare not affected. We should probably compare how these urls are built.Edited by username-removed-635423moved from gitlab-foss#25111 (moved)
