Issues list search and filters bar

@victorwu: Here is the list of next steps for us to prioritize with the search bar work. While some of the high priority items may seem small, this is a feature where the micro-interaction details are key for it to really shine and feel great. Thanks!

added ~874211 ~14281 ~13921 labels

Thanks @awhildy

Let's revisit this and scope out the next iteration once 8.15 is officially released and see what is clearly working on GitLab.com.

mentioned in issue gitlab-foss#26098 (closed)

changed title from New search/filters bar - Second iteration to Issues search/filters bar

mentioned in issue gitlab-foss#26652 (closed)

mentioned in merge request gitlab-foss!7345 (merged)

mentioned in issue gitlab-foss#26670 (closed)

@victorwu: This issue came up in a conversation with the UXers at the summit (@cperessini @dzaporozhets @dimitrieh @tauriedavis @pedroms @sarahod). The concern came up about not implementing the same design on the Merge Requests list (https://gitlab.com/gitlab-org/gitlab-ce/merge_requests) that we have on the Issues list. There is a feeling that these two list pages should be kept in sync. @dzaporozhets mentioned that it should be pretty easy from a technical perspective to translate the current design to the Merge Request list. Do you have an idea of how much work that is, thoughts on that priority, and if we can get that done sooner rather than later? Thanks!

@awhildy : Yep, this makes sense. Basically should we go deep first or wide first?

My initial thoughts are that we should do a few more iterations on the issues side first before porting the design over to merge requests (that's the existing order in the issue description above). That way we can compare the two designs in production. And if we have to tweak the design based on feedback, we can do it in one area, get it to a steady state, and then port it.

The alternative is to go wide first, and port to merge requests with whatever we have. This is driven more by consistency as soon as possible, I guess?

I don't have strong opinion either way. Either way, we'll prioritize something (see https://gitlab.com/gitlab-org/gitlab-ce/issues/26259). I'm pushing for next iterations on 8.17.

Engineers can comment on effort required.

I think it makes sense to bring it over to MRs after the first iteration from a usability standpoint, we would just want to have better test coverage to make sure nothing gets missed. It's not trivial but its not extremely difficult to do.

We have a few ideas for next steps to improve usability at the top in the description. Let's aim for this in 8.17 and anything else that we can determine are major usability pain points. And then let's port to merge requests as a stretch goal. But for 8.17 I'd say let's get it to stable place where everyone is comfortable with the basic usability: https://gitlab.com/gitlab-org/gitlab-ce/issues/26749.

Adding arrow keys would be really helpful!

mentioned in issue gitlab-foss#26785 (closed)

I would say it should be brought to MRs as soon as possible after issues. Having different UX on basically same pages is annoying to me.

Nice! A filter for participants of an issue would be also very helpful for us

I've created both gitlab-foss#26840 (closed) and gitlab-foss#26841 (closed)

I've also created https://gitlab.com/gitlab-org/gitlab-ce/issues/26844 (New search bar performs a new request for each 'tag'), if someone could add mine and ZJ's issues to the list above, that would be great!

Thanks @zj + @smcgivern. They are in the list. I'll update the priorities a bit once we get some more discussion / feedback from UX.

If we move the search bar to the MR tab, is that the only work we can plan for in 8.17? Trying to balance largest usability concerns with easiest to quickly address. Thanks!

mentioned in issue gitlab-foss#26749 (closed)

added meta in GitLab FOSS label

marked the task gitlab-foss#26882 (closed) Hard to filter by "Me" with current filter dropdown as completed

marked the task gitlab-foss#26884 (closed) Issues: broken issue search / filtering + new issue search totally sucks as completed

marked the task gitlab-foss#26841 (closed) No tabcomplete on search suggestions as completed

marked the task gitlab-foss#26959 (closed) Added current user filter to assignee dropdown as completed

marked the task gitlab-foss#26955 (closed) Filter issues input does not show assignee name when there is an assignee ID in the URL as completed

marked the task gitlab-foss#26617 (closed) Search bar filter dropdown does not dismiss when sort dropdown is selected as completed

marked the task gitlab-foss#26623 (closed) Search bar dropdown doesn't load when you go back in browser history as completed

marked the task gitlab-foss#26785 (closed) Search bar not working on IE as completed

marked the task gitlab-foss#26623 (closed) Search bar dropdown doesn't load when you go back in browser history as incomplete

marked the task gitlab-foss#26623 (closed) Search bar dropdown doesn't load when you go back in browser history as completed

mentioned in issue gitlab-foss#26945 (closed)

mentioned in merge request gitlab-foss!8681 (merged)

mentioned in issue gitlab-foss#27057 (closed)

@victorwu Just to give you a heads up, we now have some videos of users interacting with the issue filter. I have 2 videos so far, which I've analysed and I hope to have the final 3 videos by the end of tomorrow. You can find my analysis within my [research plan] (gitlab-foss#26945 (closed) ).

You will also find in the plan, direct links to the videos on YouTube. I've timestamped them so you can skip to the most relevant bits imo.

If you want to discuss any of the research (e.g. why tasks are worded in a particular way) then do feel free to schedule a call with me.

Thanks @sarahod . I'll review this soon hopefully today or tomorrow, and based on that, clean up some issues here and you can help with some of the priority of major pain points. Thanks!

@victorwu see also gitlab-foss#27057 (closed) and gitlab-foss#26835 (closed) which aren't covered in this issue.

marked the task gitlab-foss#26670 (closed) Auto space and dropdown in issues search bar as completed

marked the task Can’t multi-select labels with mouse, can only do it by typing - attempting to do it via mouse unexpectedly clears currently selected label filter as completed

marked the task Once label is typed in search field, clicking back in search field doesn’t display all top-level filter options, only labels - have to press space to get all other options as completed

marked the task Clicking on "Keep typing and press Enter" should perform the search as completed

@victorwu looks like @iamphill already got filter dropdowns to open based on where the cursor selection is. Do we want the big goal for %8.17 in gitlab-foss to be to move the filtered search to the merge requests page?

marked the task gitlab-foss#26652 (closed) View and edit tokens in issues search bar as completed

@ClemMakesApps : I think https://gitlab.com/gitlab-org/gitlab-ce/issues/26652 hasn't been solved yet? I added a comment there. After that, I agree it's stable enough to move to merge requests page. I'll add an issue and put it in the description.

mentioned in issue gitlab-foss#27131 (closed)

changed title from Issues search/filters bar to Issues list search and filters bar

mentioned in issue gitlab-foss#24688 (closed)

mentioned in issue gitlab-foss#21747 (closed)

marked the task gitlab-foss#26652 (closed) View and edit tokens in issues search bar as incomplete

@ClemMakesApps we also need to address the issue that @smcgivern brought up. Very important. Can we take a look at that regression first?

yes @jschatz1, that MR is already in review

mentioned in issue gitlab-foss#27235 (moved)

mentioned in issue gitlab-foss#27238 (moved)

mentioned in issue gitlab-foss#27239 (moved)

mentioned in issue gitlab-foss#27286 (moved)

mentioned in issue gitlab-foss#27293 (closed)

marked the task gitlab-foss#26840 (closed) Searching issue filters should be keyboard selectable as completed

marked the task gitlab-foss#26844 (closed) New search bar performs a new request for each 'tag' as completed

marked the task gitlab-foss#27176 (closed) Filtered search bar assigned to me option as completed

marked the task gitlab-foss#26670 (closed) Can't multi-select labels with mouse, can only do it by typing - attempting to do it via mouse unexpectedly clears currently selected label filter as completed

mentioned in issue gitlab-foss#27262 (closed)

mentioned in issue gitlab-foss#27747 (moved)

mentioned in issue gitlab-foss#27414 (moved)

mentioned in issue gitlab-foss#27261 (closed)

mentioned in issue gitlab-foss#22921 (closed)

marked the task 9.0 gitlab-foss#27131 (closed) New interface for merge requests list search and filter as completed

mentioned in issue gitlab-foss#29362 (closed)

mentioned in issue ux-research#1 (closed)

Do we have an issue for rolling this out to Groups and Dashboard?

Maybe we should reference this issue:

https://gitlab.com/gitlab-org/gitlab-ce/issues/29532

marked the task 9.0 gitlab-foss#26652 (closed) Add token UI for filtered search bar as completed

marked the task gitlab-foss#22921 (closed) Show current user immediately in filters as completed

marked the task gitlab-foss#28312 (closed) New interface for boards search and filter as completed

marked the task gitlab-foss#27174 (closed) Frontend allows to filter issues by 2 milestones although it is not possible as completed

marked the task gitlab-foss#27293 (closed) Applying the same filter twice in the issue filter as completed

This is a lot of stuff. @victorwu should we prioritize fixing this for %9.2 in gitlab-foss

marked the checklist item gitlab-foss#27262 (closed) Add option to store recent history of the filtered search as completed

@jschatz1 : What do you mean? We have a few issues I think for improving the search bar. Like the label colors and introducing the xs. Nothing urgent here I think?