Uploading file via web interface into a folder that has a space in the name fails

Summary

At GitLab.com, Uploading file via web interface into a folder that has a space in the name fails and leads to a misleading error message. This problem was reported before but the issue was closed.

Steps to reproduce

1. Create a folder with spaces in the name
2. Navigate into it via Web UI
3. Click on the plus sign and select Upload file
4. Drag and drop or click to upload any file (with or without spaces)
5. Click upload file

Expected behavior

1. File created on Repository
2. Message: The file has been successfully created. in the UI

Actual behavior

1. File is not created
2. An error message appears in the UI `Your changes could not be commited, because the file name can contain only letters, digits, '_', '-', '@' and '.'. Separate directories with a '/'.

Relevant logs and/or screenshots

Output of checks

This bug happens on GitLab.com

Results of GitLab application Check

N/A

Results of GitLab environment info

N/A

Possible fixes

Sorry, I'm not fluent enough with the source to know where to find these validations

Are you saying a file with a space in the name or a file with double quotes in the name? Please provide the filename in question.

added ~65372 label

changed title from Uploading file via web interface into a folder that has " " in the name fails to Uploading file via web interface into a folder that has a space in the name fails

Hi @mattl - it's spaces. I've fixed the issue title.

It can by any file name - as long as the folder has a space in the name, it fails to upload a file or even to create a new file from the UI, such as in the image below (see the Templates and images folder):

Okay, that makes things clearer.

added 12980 gitlab-foss155949 reproduced on GitLab.com in GitLab FOSS labels

removed 65372 12980 gitlab-foss155949 gitlab-foss27047 labels

added 12980 gitlab-foss155949 reproduced on GitLab.com in GitLab FOSS labels

mentioned in issue gitlab-foss#26540 (closed)

While you are at it, a comma is also disallowed when using the upload in the gitlab.com GUI. Uploading & browsing files with filenames containing spaces or comma via the git cli works as expected.

Related to: gitlab-foss#21362 (closed) @mydigitalself

changed milestone to %9.4 in gitlab-foss

Gitlab should be able to work with any file or directory that git itself can. That means it should be EXTREMELY lenient, blocking files with "/" and NUL, and that's about it (on unix, but the idea is to rely on git underneath to complain appropriately, not to second guess it).

This is still an issue. As @fmoraes.daitan documents in detail above "as long as the folder has a space in the name, it fails to upload". Easy to reproduce.

moved from gitlab-foss#26187 (moved)