20160616103948 CE migration conflicts with EE migration 20160301174731

ZenDesk issue: https://gitlab.zendesk.com/agent/tickets/28675

These two files both try to add an index to the same column:

• EE: https://gitlab.com/gitlab-org/gitlab-ee/blob/master/db/migrate/20160301174731_add_fingerprint_index.rb
• CE: https://gitlab.com/gitlab-org/gitlab-ce/blob/master/db/migrate/20160616103948_add_unique_index_to_keys_fingerprint.rb

If you attempt to upgrade from 8.9.1 CE to 8.9.4 EE, you get a bad error:

Index name 'index_keys_on_fingerprint' on table 'keys' already exists` - `20160301174731_add_fingerprint_index.rb`

I think we may need to check for the existence of this index before inserting.

it's weird because we already check for that - https://gitlab.com/gitlab-org/gitlab-ce/blob/master/db/migrate/20160616103005_remove_keys_fingerprint_index_if_exists.rb before trying to create the unique index

There's an order of operations issue here. If you installed 8.9.1 CE, you get both CE migrations:

   up     20160616103005  Remove keys fingerprint index if exists
   up     20160616103948  Add unique index to keys fingerprint

The failure happens when the EE migration attempts to apply 20160301174731_add_fingerprint_index.rb.

Ohh I noticed when trying to reproduce the situation, I didn't think in this case.

Milestone changed to gitlab-org/gitlab-ce%25

This happened again to another customer. I think we're going to want to put this into a patch release for EE.

ZD: https://gitlab.zendesk.com/agent/tickets/29344

/cc: @rspeicher

The current workaround via @MrChrisW:

1. Mark the migration as complete using gitlab-rake gitlab:db:mark_migration_complete[20160301174731].
2. Run gitlab-ctl reconfigure

Added gitlab-org/gitlab-ce~113220 label

Moved from gitlab-org/gitlab-ce#19622

mentioned in merge request !539 (merged)

Status changed to closed by merge request !539 (merged)

Added ~149424 label

Removed ~149424 label

mentioned in commit 5c62e476

Mentioned in commit 5c62e476