Approval requirements for MRs
customer feedback:
Need to be able to customize approval requirements. Gerrit has the ability to add custom “approval” controls. This makes it possible for us to easily constrain a branch during stabilization periods such that manager approval is required before a submission can be merged. This also provides an audit trail, showing who approved it, at what time, etc.
Activity
Mentioned in issue #580
@JobV @smcgivern I don't understand this issue. If it's about per branch approval, we have an issue for that. If it's about about trail, ok. Is it about something else?
@regisF I think you're right, the core of this request looks to be the same as #460, assuming that the request is for something like this: https://gerrit-review.googlesource.com/Documentation/config-labels.html#label_branch
I think audit trails should go in a separate issue (maybe even reuse this one?) as it's important we don't lose that request.
-
@smcgivern I was about to create an issue for the audit trail, but then I realized we already provide the information of who approved a MR and at what time. What else would we need to display?
@regisF do we show when it was approved? Maybe I'm misremembering. Anyway, I think this is more important once we allow revoking approvals - at the moment it doesn't add much.
-
@smcgivern This is what we have right now. However we don't have a system message for merge request approval. You are right, once we have revoking approvals, we'll have to consider it as well. I've added a comment on the issue about that.
@regisF that's not an approval, though? It's a merge, which doesn't have to be done by any of the approvers. It looks something like this:
-
@smcgivern facepalm. My bad.
