When adding a deploy key that already exists, display the title

Description

We should display the title of an existing deploy key if a user is trying to readd it

The problem is that I have a lot of keys and I don't know which key is matching and I can't change the machine key.

Proposal

Upon attempting to add a duplicated key, display the title of the existing key so it can be identified:

Fingerprint has already been taken by My Deploy Key

Provided that the following conditions are met:

• The user adding the key has access to the existing deploy key

If the above conditions aren't met, the current generic message should be displayed:

Fingerprint has alredy been taken

And give away no further information about the existing deploy key

@briann Should we do this?

added 480950 gitlab-foss14213 labels

@markglenfletcher so long as we verify that the user has access to that deploy key I don't see a reason not to do this.

OK. So show the title of the matching deploy key if the user has access otherwise show the current message

@joseramonc What do you think?

I think it would be awesome!

changed title from When adding a duplicated deploy key for a project, it should tell me which key alredy have that fingerprint to When adding a deploy key that already exists, display the title

OK. Let's open this for a Community Contribution in GitLab FOSS. I have updated the description to reflect the circumstances where the additional guidance should be displayed

added Accepting Merge Requests in GitLab FOSS label

mentioned in merge request gitlab-foss!12926

@hetsketch Thanks for working on this one. I've assigned you to this issue

assigned to @hetsketch

changed milestone to %9.5 in gitlab-foss

changed weight to 2

moved from gitlab-foss#29276 (moved)