deny_delete_tag push rules don't work

If I configure push rules for a project and activate the deny_delete_tag rule, I can still delete tags vía push.

Added regression label

The fix is actually very simple:

--- a/lib/gitlab/checks/change_access.rb
+++ b/lib/gitlab/checks/change_access.rb
@@ -115,3 +115,3 @@ module Gitlab
           if push_rule.deny_delete_tag && protected_tag?(tag_name(@ref)) && Gitlab::Git.blank_ref?(@newrev)
-            "You can not delete tag"
+            return "You can not delete tag"
           end

My question is regarding the specs that I should add for this. This class currently has no specs, I found this regression while working on other changes on this file. For those changes I have a CE merge request to add specs for the behaviour there (see https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/5799, WIP) and I was planning to add the examples for the EE behaviour on top of that after it got merged, but since this is a regression, I don't know if I should create a spec file with only an example for this regression on the MR for this issue, or what should I do?

/cc @DouweM @rspeicher

@eReGeBe Sorry, I'm not totally understanding your question.

I think just add a spec that ensures the correct behavior.

mentioned in merge request !681 (merged)

mentioned in commit 8d0d6e01

Milestone changed to %8.11

Added ~481018 label

Milestone changed to %8.12

Milestone changed to %8.13

Milestone changed to %8.14

Milestone changed to %8.15

@eReGeBe What is the status here?

changed milestone to %8.16

@DouweM this was already fixed with https://gitlab.com/gitlab-org/gitlab-ee/merge_requests/681 so we can close this.

closed