Moving an issue does not close it automatically

If you encounter this happening, please log the issue below and when it happened.

Issues where this has occurred

• https://gitlab.com/gitlab-org/gitlab-ce/issues/29910
• https://gitlab.com/gitlab-org/gitlab-ce/issues/29907
• https://gitlab.com/gitlab-org/gitlab-ce/issues/33464

added regression in GitLab FOSS label

added ~874211 label

added ~14281 label

Happened to @markglenfletcher in https://gitlab.com/gitlab-org/gitlab-ce/issues/29907 too.

mentioned in issue gitlab-foss#29527 (closed)

added Next Patch Release in GitLab FOSS label

mentioned in issue gitlab-foss#29907 (closed)

Another instance of that for @zj's issue move here:

• https://gitlab.com/gitlab-org/gitlab-ce/issues/29865

assigned to @jarka

This one is weird...

Trying to replicate the behaviour without success locally and using some testing projects on gitlab.com - works for me, issues are being closed.

I don't see any changes that could cause the problem (basically no changes in move_service or close_service) and I don't see how this could be happening in general.

Code responsible for moving/closing issues:

ActiveRecord::Base.transaction do
    # New issue tasks
    #
    @new_issue = create_new_issue

    rewrite_notes
    rewrite_award_emoji
    add_note_moved_from

    # Old issue tasks
    #
    add_note_moved_to
    close_issue
    mark_as_moved
  end

As can be seen on issues https://gitlab.com/gitlab-org/gitlab-ce/issues/29910 or https://gitlab.com/gitlab-org/gitlab-ce/issues/29865 - new issues were created, both notes (moved to and moved from) were created as well. However issue was not closed and also moved_to_id is NULL as can be seen on the json page.

/cc @smcgivern

@jarka that is weird, indeed! I don't see anything that would cause it. Even if we somehow thought the user didn't have permissions to close the issue, we should still set moved_to_id.

Are you able to reproduce on the GitLab CE project itself? I don't see anything in Sentry or Kibana that indicates a problem The other thing I'd do is just double-check that the stable branch on EE looks right, in case it's different to CE.

I was able to move https://gitlab.com/gitlab-org/gitlab-ce/issues/29960 just fine. Is it possible the spam checker is causing the original issue not to be updated? I didn't see any entries in the log.

@stanhu hmm there is an issue because of spam checker. However I think it is not the issue described here. I was able to do this locally:

• I have an issue 985 in Project1
• I am moving the issue to Project2
• the issue is recognised as a spam I am asked to solve the reCaptcha
• a new issue is not created (because of spam checker) but a note for the issue 985 that it was moved is created anyway
• when I solve the reCaptcha a completely new issue is created in Project1

I tried also editing description / title just to test and it works correctly (issue updated after solving reCaptcha).

Also I think that the issue described by me is not relevant anymore as we will check only title/description change (https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/10104)

I can't seem to reproduce this now either. I was able to move issues today fine. Now I'm wondering if there was some weirdness caused by DB load balancing.

mentioned in issue gitlab-foss#30324 (closed)

mentioned in issue gitlab-foss#30494 (closed)

@stanhu @markglenfletcher @smcgivern Have we experienced the problem since beginning of April? I suggest closing this issue if not unless you suggest further investigation.

Yeah, I haven't seen this again. I'm fine with closing it.

closed

We saw this again here:

• https://gitlab.com/gitlab-org/gitlab-ce/issues/33464

mentioned in issue gitlab-foss#33464 (closed)

reopened

I am unassigning it because I'll be on vacations until the end of June. Everything we figured out (which means almost nothing ) is described in the comments

removed assignee

While this may have been a regression in GitLab FOSS initially, it's clearly a) hard to figure out and b) not going to be backported to 9.0.

@victorwu I'm going to let you decide on the priority of this.

changed title from Moving an issue in 9.0 did not close it to Moving an issue does not close it automatically

removed regression in GitLab FOSS label

changed milestone to %Next 3-6 months in gitlab-foss

@smcgivern : Let's keep logging instances of this until we have enough data that we can determine the root cause. Right now it's not reliably reproducible right? So let's just punt it until we can see it happen more regularly.

changed the description

moved from gitlab-foss#29911 (moved)