500 when pushing code to instance without license configured

This is a first bug found by end to end tests. Tested with gitlab/gitlab-ee:latest.

It appears that when you push code to GitLab instance when there is no license configured, GitLab will respond with 500 instead of informing that license is required.

NameError (undefined local variable or method `new_admin_license_path' for LicenseHelper:Module):
  app/helpers/license_helper.rb:49:in `no_license_message'
  app/helpers/license_helper.rb:16:in `license_message'
  lib/gitlab/git_access.rb:99:in `user_push_access_check'
  lib/gitlab/git_access.rb:73:in `push_access_check'
  lib/gitlab/git_access.rb:43:in `check'
  app/controllers/projects/git_http_controller.rb:92:in `access_check'
  app/controllers/projects/git_http_controller.rb:102:in `receive_pack_allowed?'
  app/controllers/projects/git_http_controller.rb:9:in `info_refs'
  lib/gitlab/request_profiler/middleware.rb:15:in `call'
  lib/gitlab/middleware/go.rb:16:in `call'
  lib/gitlab/middleware/readonly_geo.rb:29:in `call'

See https://gitlab.com/gitlab-org/gitlab-qa/builds/3334896

Spec

• When pushing code to an instance with no license set, return a message through git similar to

remote: 
remote: You need to add a valid license in your GitLab instance to complete this operation.
remote: 

cc @stanhu @DouweM

Good find!

@grzesiek @stanhu let's fix that in 8.17.

changed milestone to %8.17

added ~481018 label

Just hit this. Glad to see there's already an issue.

@DouweM can this be put on your radar somehow?

added Deliverable label

assigned to @pchojnacki

mentioned in merge request !1133 (merged)

I've changed the message to: For admin:

No GitLab Enterprise Edition license has been provided yet.
Pushing code and creation of issues and merge requests has been disabled.

Upload a license in the admin area: http://localhost/admin/license/new

For normal user:

No GitLab Enterprise Edition license has been provided yet.
Pushing code and creation of issues and merge requests has been disabled.

Ask an admin to upload a license

The message now displays correctly when pushing through ssh. But the workhorse to not process the message contents correctly and just returns 403 error.

@DouweM ^^ should I work the bug in Workhorse in a separate Issue or continue in this one ?

@pchojnacki Thanks for the MR!

However I find the new messages confusing compared to what was in the body of the issue.

We don't need to mention that the creation of issues and MR have been disabled, as this message is sent in the context of you pushing through the console. You don't care about the creation of issues at this point.

@regisF The message I've put is what actually was supposed to be there before but didn't work because of the method availability in this context I think its the same message that pops up when you go to EE webpage. So my reasoning for keeping the message was to be consistent with that, but its no problem I'll change the message to the one suggested in the Issue.

Ok, I've checked workhorse and found out that it was Rails app that was overriding the message in the end. So I have everything working now. One thing that remains is Whitespace. Seems like git-binary is trimming whitespaces on incoming messages. Which means that currently this is the best output I'm able to get:

MBP-Pawel:flight pawel$ git push
Username for 'http://localhost:3001': root
Password for 'http://root@localhost:3001':
remote: You need to add a valid license in your GitLab instance to complete this operation.
fatal: unable to access 'http://localhost:3001/twitter/flight.git/': The requested URL returned error: 403

Even though - I've verified this via Wireshark - leading and trailing whitespaces are sent to the client.

closed

Thanks for handling this quickly, @pchojnacki. It's adds some polish for EE.