Add webhooks for when a merge request is approved

• Zendesk ticket: https://gitlab.zendesk.com/agent/tickets/12815

Requested feature

Right now we have webhooks for almost all events surrounding the merge request process, but we don;t have anything setup for when a merge request has been approved, thus this feature request.

Concrete questions / Next steps

I think there are two ways in which we could implement this:

• Fire a webhook every time someone approves
• Fire a webhook when the MR has reached the minimum number of approvers

I'm leaning for the second alternative, as it would create less noise and, in my opinion, it focuses on the actual event that is relevant for the status of the merge request.

@JobV what do you think of this?

/cc @vsizov

I can't imagine the case when it's needed but it's not hard to implement.

@vsizov maybe as part of moving some process further.

@patricio what does the customer want?

@JobV the customer would like a webhook to fire when a merge request is approved and ready to merge. With the information from the web hook, the merge request can then be accepted automatically via the API.

@patricio so let's do that, I see no reason against it and it makes it nicer to work with external services.

Milestone changed to 8.6

@vsizov, I just needed it today. To speed up the validation process, I wanted my Slack bot to alert someone when a merge request was approuved. But it is not yet implemented

At the same time, I wanted to simplify labelizing of MR by making some hooks on MR comments when they are saved but there is no such event. I might create an issue for that but this is probably done with the 'comment' trigger (haven't tested yet). (tested and already possible)

+1 for this feature.

We are adding/removing labels based on the approval status of a merge request. This is only possible through polling in current versions, would be awesome if you added a web hook.

Reassigned to @rspeicher

mentioned in merge request !270 (merged)

mentioned in commit 0281b781

Status changed to closed by merge request !270 (merged)

@patricio Merged for 8.6, please report back if necessary.

mentioned in commit 881c5bf1

Thanks @rspeicher. I reported back.

mentioned in commit 34a40401

works perfectly for me! Thanks guys!

Mentioned in commit pfjason/gitlab-ce@0281b781

Mentioned in commit pfjason/gitlab-ce@881c5bf1

mentioned in commit a23bd20e

mentioned in commit 67d2a717

mentioned in commit 3174aad7