Artifacts upload error but build success

Description of the problem

In one of build executed by cron job, build success, but artifacts upload was failed. Wan run on shared runners.

Link to wrong build: https://gitlab.com/simplepackagemanager/spm/builds/16259936

Which Group/Project (with full path) is experiencing the issue?

https://gitlab.com/simplepackagemanager/spm

Approximate date/time when the error occurred.

2016-05-14

Describe what you were doing right before the issue occurred.

@grzesiek What do you think about this? The job has already been deemed successful at this point and the conditions for when to upload artifacts rely on the build status. Should the build status be overridden by the fact that the artifacts failed to be uploaded?

added awaiting feedback in GitLab.com / GitLab.com Support Tracker label

This is a very good question! I wonder what @bikebilly things. I don't think it has a high priority, though.

OK. It seems like this now belongs in the Community Edition issue tracker. Moving it there

moved from gitlab-com/support-forum#1831 (closed)

mentioned in issue gitlab-com/support-forum#1831 (closed)

I think "when: always" inside artifacts mean upload artifacts in any case if build failed or not.

But this not mean if gitlab api failed to upload artifacts don't mark build as failed.

This builds only exists for create artifacts for other projects builds. But in this case it failed, but not marked as failed.

I can try avoid this bug with downloading build logs for all success builds, and check is it really failed or not and retry builds. But this is big overhead. Please fix it.

/cc @bikebilly

https://gitlab.zendesk.com/agent/tickets/78537 (for internal use)

Related: gitlab-foss#33248 (closed)

I think that this is wrong assumption and it should mark build as failed.

@bikebilly I think it should be possible, but then this issue belongs to the GitLab Runner project, and we should check that with @tmaczukin.

moved from gitlab-foss#32249 (moved)