Resolvability of discussions in issues

In order

• https://gitlab.com/gitlab-org/gitlab-ce/issues/30299
• https://gitlab.com/gitlab-org/gitlab-ce/issues/32451
• https://gitlab.com/gitlab-org/gitlab-ce/issues/32452

Description

• When creating a discussion (either by creating the first comment, or converting an existing comment), optionally indicate that it is resolvable.
• When you resolve the discussion, you truly resolve the entire thing. There is no concept of individual comment resolvability.
• This applies to issues, merge requests (non diff), commits, and snippets.
• If a single root comment has no replies, we still show the reply panel so a user can easily reply, resolve, jump to the next discussion, and make an issue from the unresolved comments.

Mockups

changed title from Resolvability of threads in issues and non-diff merge request threads to Resolvability of discussions in issues

mentioned in issue gitlab-foss#32452 (moved)

changed the description

Updated mockups! cc @DouweM

mentioned in issue gitlab-foss#30299 (moved)

@tauriedavis continuing from my comment about the collapse/expand button, I don't think it should be at the same “level” as the actions to interact with the discussion (“Create issue for discussion” and “Jump to next discussion”). Now that I look at this, it makes me want to put the “Reply” and “Mark as resolved” actions with the same visual weight as the button actions, after all these are the most important actions one can have with the discussion.

I'm thinking about a single place with all of the actions, instead of two lines (at least when collapsed). I don't have any particular suggestions (sorry), I guess it's something to experiment with.

@tauriedavis The “Create issue for discussion” and “Jump to next discussion” options really only make sense for unresolved discussions that are expanded by default, so what do you think about only showing those when the discussion is expanded, not when it's collapsed?

I don't think I don't think we need the extra "Expand/Collapse" button, I think the one on the main discussion is fine. People are more likely to expand a collapsed discussion than the other way around, which they can do by clicking anywhere in the "2 replies" widget already.

assigned to @tauriedavis

changed milestone to %Backlog in gitlab-foss

I've updated the description based on everything we've discussed.

If a single root comment has no replies, we still show the reply panel so a user can easily reply, resolve, jump to the next discussion, and make an issue from the unresolved comments.

changed the description

changed the description

changed the description

@tauriedavis yup, that sounds/looks great. Should the checkbox label be “Mark comment as resolvable” to be consistent with the dropdown option? Also, wouldn't it be preferable to verb that option as “Mark asMake it resolvable” to differentiate making a comment resolvable from marking a comment as resolved? And finally, what's the option label for reverting the resolvability of a comment?

added UX in GitLab FOSS label

changed the description

That makes sense to me, thanks @pedroms!

removed assignee

changed milestone to %Next 2-3 months in gitlab-foss

mentioned in issue gitlab-foss#34527 (closed)

mentioned in issue ux-research#21

moved from gitlab-foss#32451 (moved)