GitLab merge requestshttps://staging.gitlab.com/gitlab-org/gitlab/-/merge_requests2017-10-06T17:48:45Zhttps://staging.gitlab.com/gitlab-org/gitlab/-/merge_requests/3078Move group boards routes under '-' and remove "boards" from reserved paths2017-10-06T17:48:45ZValery SizovMove group boards routes under '-' and remove "boards" from reserved paths## What does this MR do?
Move group boards routes under '-' and remove "boards" from reserved paths
## Are there points in the code the reviewer needs to double check?
## Why was this MR needed?
## Screenshots (if relevant)
## Does ...## What does this MR do?
Move group boards routes under '-' and remove "boards" from reserved paths
## Are there points in the code the reviewer needs to double check?
## Why was this MR needed?
## Screenshots (if relevant)
## Does this MR meet the acceptance criteria?
- [ ] [Changelog entry](https://docs.gitlab.com/ee/development/changelog.html) added, if necessary
- [ ] [Documentation created/updated](https://docs.gitlab.com/ee/development/doc_styleguide.html)
- [ ] API support added
- [ ] Tests added for this feature/bug
- Review
- [ ] Has been reviewed by UX
- [ ] Has been reviewed by Frontend
- [ ] Has been reviewed by Backend
- [ ] Has been reviewed by Database
- [ ] Conform by the [merge request performance guides](https://docs.gitlab.com/ee/development/merge_request_performance_guidelines.html)
- [ ] Conform by the [style guides](https://gitlab.com/gitlab-org/gitlab-ee/blob/master/CONTRIBUTING.md#style-guides)
- [ ] [Squashed related commits together](https://git-scm.com/book/en/Git-Tools-Rewriting-History#Squashing-Commits)
## What are the relevant issue numbers?
closes https://gitlab.com/gitlab-org/gitlab-ee/issues/3662#10.0Douwe MaanDouwe Maanhttps://staging.gitlab.com/gitlab-org/gitlab/-/merge_requests/3066Does not track renamed events for projects backed by hashed storage2020-07-09T15:23:21Zusername-removed-283999douglas@gitlab.comDoes not track renamed events for projects backed by hashed storage## What does this MR do?
Does not track renamed events for projects backed by hashed storage on the primary node.
## Are there points in the code the reviewer needs to double check?
Are _other_ actions taken on the secondary in respon...## What does this MR do?
Does not track renamed events for projects backed by hashed storage on the primary node.
## Are there points in the code the reviewer needs to double check?
Are _other_ actions taken on the secondary in response to this event that are important?
## Why was this MR needed?
Geo secondary receives a repository renamed event, and attempts `gitlab_shell.mv_project(same_path, same_path)` as a result. _Fortunately_, this will fail - the destination already exists, and gitlab-shell checks that - but I wonder if we can skip the move entirely.
## Does this MR meet the acceptance criteria?
- [x] [Changelog entry](https://docs.gitlab.com/ee/development/changelog.html) added, if necessary
- [ ] ~~[Documentation created/updated](https://docs.gitlab.com/ee/development/doc_styleguide.html)~~
- [ ] ~~API support added~~
- [x] Tests added for this feature/bug
- Review
- [ ] Has been reviewed by UX
- [ ] Has been reviewed by Frontend
- [ ] Has been reviewed by Backend
- [ ] Has been reviewed by Database
- [x] Conform by the [merge request performance guides](https://docs.gitlab.com/ee/development/merge_request_performance_guidelines.html)
- [x] Conform by the [style guides](https://gitlab.com/gitlab-org/gitlab-ee/blob/master/CONTRIBUTING.md#style-guides)
- [ ] [Squashed related commits together](https://git-scm.com/book/en/Git-Tools-Rewriting-History#Squashing-Commits)
## What are the relevant issue numbers?
Closes #350810.0username-removed-283999douglas@gitlab.comusername-removed-283999douglas@gitlab.comhttps://staging.gitlab.com/gitlab-org/gitlab/-/merge_requests/2869fix creating labels from Group Boards sidebar2020-07-09T16:06:26ZSimon Knoxfix creating labels from Group Boards sidebar## What does this MR do?
Fix namespace_path for Group Boards sidebar
## Are there points in the code the reviewer needs to double check?
## Does this MR meet the acceptance criteria?
- Tests
- [ ] Added for this feature/bug
- [ ]...## What does this MR do?
Fix namespace_path for Group Boards sidebar
## Are there points in the code the reviewer needs to double check?
## Does this MR meet the acceptance criteria?
- Tests
- [ ] Added for this feature/bug
- [ ] All builds are passing
- [ ] Conform by the [merge request performance guides](http://docs.gitlab.com/ee/development/merge_request_performance_guidelines.html)
- [ ] Conform by the [style guides](https://gitlab.com/gitlab-org/gitlab-ee/blob/master/CONTRIBUTING.md#style-guides)
- [ ] Branch has no merge conflicts with `master` (if it does - rebase it please)
- [ ] [Squashed related commits together](https://git-scm.com/book/en/Git-Tools-Rewriting-History#Squashing-Commits)
## What are the relevant issue numbers?
Closes #336910.0Simon KnoxSimon Knoxhttps://staging.gitlab.com/gitlab-org/gitlab/-/merge_requests/2855show horizontal scrollbar on issue boards in focus mode2020-07-09T15:15:33ZSimon Knoxshow horizontal scrollbar on issue boards in focus mode## What does this MR do?
Fix height of issue boards in focus mode so the horizontal scrollbar is visible
Topbar height is 70px, not 50
## Are there points in the code the reviewer needs to double check?
## Screenshots (if relevant)
...## What does this MR do?
Fix height of issue boards in focus mode so the horizontal scrollbar is visible
Topbar height is 70px, not 50
## Are there points in the code the reviewer needs to double check?
## Screenshots (if relevant)
![Screen_Shot_2017-09-07_at_5.12.18_pm](/uploads/f889feb75b6bcb6b590419df1aae39d7/Screen_Shot_2017-09-07_at_5.12.18_pm.png)
## Does this MR meet the acceptance criteria?
- [x] [Changelog entry](https://docs.gitlab.com/ce/development/changelog.html) added, if necessary
- Tests
- [ ] Added for this feature/bug
- [ ] All builds are passing
- [x] Conform by the [merge request performance guides](http://docs.gitlab.com/ee/development/merge_request_performance_guidelines.html)
- [x] Conform by the [style guides](https://gitlab.com/gitlab-org/gitlab-ee/blob/master/CONTRIBUTING.md#style-guides)
- [x] Branch has no merge conflicts with `master` (if it does - rebase it please)
- [x] [Squashed related commits together](https://git-scm.com/book/en/Git-Tools-Rewriting-History#Squashing-Commits)
## What are the relevant issue numbers?
Closes #268010.0Simon KnoxSimon Knoxhttps://staging.gitlab.com/gitlab-org/gitlab/-/merge_requests/2801Port "Extend API: Pipeline Schedule Variable" to EE2020-07-09T16:48:09ZShinya MaedaPort "Extend API: Pipeline Schedule Variable" to EE## What does this MR do?
Port "Extend API: Pipeline Schedule Variable" to EE, due to ee-compat failure.
I just fixed
```diff
> g di
diff --cc lib/api/entities.rb
index e3771acdd7,9cac2ff248..0000000000
--- a/lib/api/entitie...## What does this MR do?
Port "Extend API: Pipeline Schedule Variable" to EE, due to ee-compat failure.
I just fixed
```diff
> g di
diff --cc lib/api/entities.rb
index e3771acdd7,9cac2ff248..0000000000
--- a/lib/api/entities.rb
+++ b/lib/api/entities.rb
@@@ -875,14 -818,7 +875,14 @@@ module AP
class Variable < Grape::Entity
expose :key, :value
- expose :protected?, as: :protected
+ expose :protected?, as: :protected, if: -> (entity, _) { entity.respond_to?(:protected?) }
+
+ # EE
+ expose :environment_scope, if: ->(variable, options) {
+ if variable.respond_to?(:environment_scope)
+ variable.project.feature_available?(:variable_environment_scope)
+ end
+ }
end
class Pipeline < PipelineBasic
```
## What are the relevant issue numbers?
- https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/13653
- https://gitlab.com/gitlab-org/gitlab-ce/issues/3451810.0Shinya MaedaShinya Maedahttps://staging.gitlab.com/gitlab-org/gitlab/-/merge_requests/2063WIP: Elasticsearch only finds first occurrence in a file2020-07-09T16:44:49ZValery SizovWIP: Elasticsearch only finds first occurrence in a file## What does this MR do?
It shows few occurrences for the same file.
## Are there points in the code the reviewer needs to double check?
## Why was this MR needed?
## Screenshots (if relevant)
## Does this MR meet the acce...## What does this MR do?
It shows few occurrences for the same file.
## Are there points in the code the reviewer needs to double check?
## Why was this MR needed?
## Screenshots (if relevant)
## Does this MR meet the acceptance criteria?
- [ ] [Changelog entry](https://docs.gitlab.com/ce/development/changelog.html) added, if necessary
- [ ] [Documentation created/updated](https://gitlab.com/gitlab-org/gitlab-ee/blob/master/doc/development/doc_styleguide.md)
- [ ] API support added
- Tests
- [ ] Added for this feature/bug
- [ ] All builds are passing
- [ ] Conform by the [merge request performance guides](http://docs.gitlab.com/ee/development/merge_request_performance_guidelines.html)
- [ ] Conform by the [style guides](https://gitlab.com/gitlab-org/gitlab-ee/blob/master/CONTRIBUTING.md#style-guides)
- [ ] Branch has no merge conflicts with `master` (if it does - rebase it please)
- [ ] [Squashed related commits together](https://git-scm.com/book/en/Git-Tools-Rewriting-History#Squashing-Commits)
## What are the relevant issue numbers?
closes https://gitlab.com/gitlab-org/gitlab-ee/issues/66810.0Valery SizovValery Sizov