GitLab merge requestshttps://staging.gitlab.com/gitlab-org/gitlab/-/merge_requests2017-09-20T10:06:43Zhttps://staging.gitlab.com/gitlab-org/gitlab/-/merge_requests/2719[EE] Greatly reduce test duration for git_access_spec2017-09-20T10:06:43ZRobert Speicher[EE] Greatly reduce test duration for git_access_specEE version of https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/13675
This spec is slow -- 20+ minutes on CI. Numbers below are local.
### Baseline
```
Factory usage counts:
name total avg coun...EE version of https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/13675
This spec is slow -- 20+ minutes on CI. Numbers below are local.
### Baseline
```
Factory usage counts:
name total avg count
project-repository 121.871 0.116 1049
user 78.694 0.031 2569
merge_request 60.41 0.135 448
namespace 40.125 0.038 1065
protected_branch 3.396 0.008 432
group 2.442 0.013 192
Finished in 12 minutes 10 seconds (files took 15.44 seconds to load)
1067 examples, 0 failures
```
### Post cherry-pick of https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/13675
```
Factory usage counts:
name total avg count
project-repository 36.574 0.108 338
merge_request 22.779 0.136 168
user 20.53 0.028 746
namespace 12.03 0.034 354
group 2.455 0.013 192
deploy_key 1.825 0.13 14
protected_branch 1.608 0.007 222
Finished in 3 minutes 51.1 seconds (files took 14.22 seconds to load)
356 examples, 0 failures
```
### Refactor `run_group_permission_checks`
This uses the same thinking as the earlier `run_permission_checks`
refactor, to run all of the checks for the matrix in a single `it` block
to avoid repeated setup.
```
Factory usage counts:
name total avg count
project-repository 19.041 0.112 170
user 8.969 0.03 298
merge_request 7.754 0.138 56
namespace 6.641 0.036 186
Finished in 1 minute 44.65 seconds (files took 0.91818 seconds to load)
188 examples, 0 failures
```
:tada:
### Fix invalid GitAccess specs for License and secondary Geo node
Due to a logic error, these specs weren't actually doing anything -- we
were running the checks on `Hash.new(Hash.new(false))`, which is just
`{}`.
### Refactor `push_rule_check` GitAccess specs
- Reduces duplication of long ref strings
- Passes push rule attributes directly to `create_push_rule`, rather
than creating one and then updating it.9.5Douwe MaanDouwe Maanhttps://staging.gitlab.com/gitlab-org/gitlab/-/merge_requests/2927Enable ee_compat_check for forks, but not EE2017-09-20T11:31:11Zusername-removed-423915Enable ee_compat_check for forks, but not EEEE counterpart of https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/14189
## What does this MR do?
Enable ee_compat_check for forks, but not EE
## Are there points in the code the reviewer needs to double check?
EE of course doe...EE counterpart of https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/14189
## What does this MR do?
Enable ee_compat_check for forks, but not EE
## Are there points in the code the reviewer needs to double check?
EE of course doesn't need this, but could we do this without having conflicts?10.1username-removed-128633username-removed-128633https://staging.gitlab.com/gitlab-org/gitlab/-/merge_requests/2935- Expand EE license use for development and testing2017-09-20T14:43:51ZJamie Hurewitz- Expand EE license use for development and testingThis is to allow developers rights to the EE code.This is to allow developers rights to the EE code.10.1Jacob SchatzJacob Schatzhttps://staging.gitlab.com/gitlab-org/gitlab/-/merge_requests/2961Rework Geo::BaseSchedulerWorker to be clearer and log per-loop information2017-09-20T17:24:32ZNick ThomasRework Geo::BaseSchedulerWorker to be clearer and log per-loop information## What does this MR do?
Reworks `Geo::BaseSchedulerWorker`. This affects `Geo::RepositorySyncWorker` and other children, improving the logging output and so increasing visibility into scheduling actions.
## Are there points in the cod...## What does this MR do?
Reworks `Geo::BaseSchedulerWorker`. This affects `Geo::RepositorySyncWorker` and other children, improving the logging output and so increasing visibility into scheduling actions.
## Are there points in the code the reviewer needs to double check?
## Why was this MR needed?
It's hard to work out what the workers are doing at the moment.
## Screenshots (if relevant)
The geo.log output now looks like:
```json
{"severity":"INFO","time":"2017-09-20T12:34:02.839Z","class":"Geo::RepositorySyncWorker","message":"Started scheduler"}
{"severity":"INFO","time":"2017-09-20T12:34:02.851Z","class":"Geo::RepositorySyncWorker","message":"Loop 0","enqueued":0,"pending":0,"scheduled":0}
{"severity":"INFO","time":"2017-09-20T12:34:02.852Z","class":"Geo::RepositorySyncWorker","message":"Finished scheduler","total_loops":1,"duration":0.0130841,"reason":"last_batch"}
{"severity":"INFO","time":"2017-09-20T12:34:03.312Z","class":"Geo::RepositorySyncWorker","message":"Started scheduler"}
{"severity":"INFO","time":"2017-09-20T12:34:03.324Z","class":"Geo::RepositorySyncWorker","message":"Loop 0","enqueued":0,"pending":0,"scheduled":0}
{"severity":"INFO","time":"2017-09-20T12:34:03.325Z","class":"Geo::RepositorySyncWorker","message":"Finished scheduler","total_loops":1,"duration":0.012965368,"reason":"last_batch"}
{"severity":"INFO","time":"2017-09-20T12:34:03.863Z","class":"Geo::RepositorySyncWorker","message":"Started scheduler"}
{"severity":"INFO","time":"2017-09-20T12:34:03.872Z","class":"Geo::RepositorySyncWorker","message":"Loop 0","enqueued":0,"pending":0,"scheduled":0}
{"severity":"INFO","time":"2017-09-20T12:34:03.872Z","class":"Geo::RepositorySyncWorker","message":"Finished scheduler","total_loops":1,"duration":0.010279015,"reason":"last_batch"}
{"severity":"INFO","time":"2017-09-20T12:34:05.325Z","class":"Geo::RepositorySyncWorker","message":"Started scheduler"}
{"severity":"INFO","time":"2017-09-20T12:34:05.327Z","class":"Geo::RepositorySyncWorker","message":"Finished scheduler","total_loops":0,"duration":0.001805815,"reason":"disabled"}
{"severity":"INFO","time":"2017-09-20T12:34:05.675Z","class":"Geo::RepositorySyncWorker","message":"Started scheduler"}
{"severity":"INFO","time":"2017-09-20T12:34:05.692Z","class":"Geo::RepositorySyncWorker","message":"Loop 0","enqueued":0,"pending":0,"scheduled":0}
{"severity":"INFO","time":"2017-09-20T12:34:05.692Z","class":"Geo::RepositorySyncWorker","message":"Finished scheduler","total_loops":1,"duration":0.017483968,"reason":"last_batch"}
{"severity":"INFO","time":"2017-09-20T12:34:06.185Z","class":"Geo::RepositorySyncWorker","message":"Started scheduler"}
{"severity":"INFO","time":"2017-09-20T12:34:06.204Z","class":"Geo::RepositorySyncWorker","message":"Loop 0","enqueued":0,"pending":0,"scheduled":0}
{"severity":"INFO","time":"2017-09-20T12:34:06.204Z","class":"Geo::RepositorySyncWorker","message":"Finished scheduler","total_loops":1,"duration":0.020185192,"reason":"last_batch"}
{"severity":"INFO","time":"2017-09-20T12:34:07.083Z","class":"Geo::RepositorySyncWorker","message":"Started scheduler"}
{"severity":"INFO","time":"2017-09-20T12:34:07.122Z","class":"Geo::RepositorySyncWorker","message":"Loop 0","enqueued":2,"pending":0,"scheduled":2}
{"severity":"INFO","time":"2017-09-20T12:34:07.122Z","class":"Geo::RepositorySyncWorker","message":"Finished scheduler","total_loops":1,"duration":0.038848867,"reason":"last_batch"}
{"severity":"INFO","time":"2017-09-20T12:34:07.125Z","class":"Geo::RepositorySyncWorker","message":"Started scheduler"}
{"severity":"INFO","time":"2017-09-20T12:34:07.148Z","class":"Geo::RepositorySyncWorker","message":"Loop 1","enqueued":2,"pending":0,"scheduled":2}
{"severity":"INFO","time":"2017-09-20T12:34:07.148Z","class":"Geo::RepositorySyncWorker","message":"Finished scheduler","total_loops":2,"duration":0.023313049,"reason":"last_batch"}
{"severity":"INFO","time":"2017-09-20T12:34:07.151Z","class":"Geo::RepositorySyncWorker","message":"Started scheduler"}
{"severity":"INFO","time":"2017-09-20T12:34:07.174Z","class":"Geo::RepositorySyncWorker","message":"Loop 2","enqueued":2,"pending":0,"scheduled":2}
{"severity":"INFO","time":"2017-09-20T12:34:07.174Z","class":"Geo::RepositorySyncWorker","message":"Finished scheduler","total_loops":3,"duration":0.023309843,"reason":"last_batch"}
```
## Does this MR meet the acceptance criteria?
- [x] [Changelog entry](https://docs.gitlab.com/ee/development/changelog.html) added, if necessary
- [ ] Tests added for this feature/bug
- Review
- [x] Has been reviewed by Backend
- [x] Conform by the [merge request performance guides](https://docs.gitlab.com/ee/development/merge_request_performance_guidelines.html)
- [x] Conform by the [style guides](https://gitlab.com/gitlab-org/gitlab-ee/blob/master/CONTRIBUTING.md#style-guides)
- [x] [Squashed related commits together](https://git-scm.com/book/en/Git-Tools-Rewriting-History#Squashing-Commits)
## What are the relevant issue numbers?
Related to #345310.1Robert SpeicherRobert Speicherhttps://staging.gitlab.com/gitlab-org/gitlab/-/merge_requests/2952Prepare 10.0 RC5 EE release2017-09-20T18:07:56ZJarka Kadlecovajarka@gitlab.comPrepare 10.0 RC5 EE releaseMain release issue:
### Summary
This MR prepares `10-0-stable-ee` for %"10.0" (`RC5`) by merging `10-0-stable-ee-prepare-rc5` into `10-0-stable-ee`.
### MR Filter for ~"Pick into Stable" MRs
https://gitlab.com/gitlab-org/git...Main release issue:
### Summary
This MR prepares `10-0-stable-ee` for %"10.0" (`RC5`) by merging `10-0-stable-ee-prepare-rc5` into `10-0-stable-ee`.
### MR Filter for ~"Pick into Stable" MRs
https://gitlab.com/gitlab-org/gitlab-ee/merge_requests?label_name%5B%5D=Pick+into+Stable&milestone_title=10.0&scope=all&sort=updated_asc&state=merged
### MR Filter for ~"Pick into Backports" MRs
As well as picking merge requests explicitly marked for this release, you'll need to check those which need to be included in backports. Some ~"Pick into Backports" MRs won't be relevant for this release, or will have already been included; because of this you'll need to read the discussion on each MR below to decide if to include them:
https://gitlab.com/gitlab-org/gitlab-ee/merge_requests?label_name%5B%5D=Pick+into+Backports&scope=all&sort=updated_asc&state=merged
### Note to leave in MRs
```
Picked into https://gitlab.com/gitlab-org/gitlab-ee/merge_requests/2952, will merge into `10-0-stable-ee` ready for `10.0 RC5 EE`
/unlabel ~"Pick into Stable"
```
### Steps
1. Cherry-pick commits into this MR using the links for ~"Pick into Stable" and ~"Pick into Backports" above.
- This can be done by checking out `10-0-stable-ee-prepare-rc5` locally and using `git cherry-pick -m1 MERGE_COMMIT_SHA`
1. Push changes every so often and verify that the MR has been included
1. Leave a note in the MR so others can easily see that it is on track to be included in a release.
- If the MR no longer needs to be cherry-picked into further releases, remove the ~"Pick into Stable" label.
- Otherwise update the milestone to the highest release it needs to be picked into, and set ~"Pick into Backports" if it needs to be picked into other releases in addition to that one.
1. If there are any conflicts while picking MRs then attempt to resolve them; otherwise, create a new MR against the `10-0-stable-ee-prepare-rc5` branch and assign it to the author of the conflicting files.
1. Merge CE-to-EE using one of the workflows described in the [Merge CE stable changes to EE docs](https://gitlab.com/gitlab-org/release-tools/blob/master/doc/picking-into-merge-requests.md#merge-ce-stable-changes-to-ee)
1. Once this MR is green merge it to stable, preferably with a manual fast-forward merge to minimize waiting time, as described in [Merging preparation MRs into stable](https://gitlab.com/gitlab-org/release-tools/blob/master/doc/picking-into-merge-requests.md#merging-preparation-mrs-into-stable)
### Checklist
- [ ] Changes marked ~"Pick into Stable" have been picked
- [ ] Changes marked ~"Pick into Backports" have been picked
- [ ] CE->EE merge has taken place
- [ ] Conflicts resolved
- [ ] No new commits have introduced directly to the stable branch while this MR was in progress. If there are, check for a green pipeline after merging this MR.10.0Robert SpeicherRobert Speicherhttps://staging.gitlab.com/gitlab-org/gitlab/-/merge_requests/2958Fix / add instructions for installations from source to elasticsearch docs2017-09-21T05:32:09ZNick ThomasFix / add instructions for installations from source to elasticsearch docs## What does this MR do?
Mechanically adds "Installation from source" sections to all shell snippets in the elasticsearch integration doc
## Are there points in the code the reviewer needs to double check?
## Why was this MR needed?
...## What does this MR do?
Mechanically adds "Installation from source" sections to all shell snippets in the elasticsearch integration doc
## Are there points in the code the reviewer needs to double check?
## Why was this MR needed?
## Screenshots (if relevant)
## Does this MR meet the acceptance criteria?
- [x] [Documentation created/updated](https://docs.gitlab.com/ee/development/doc_styleguide.html)
- Review
- [ ] Has been reviewed by Backend
- [x] Conform by the [style guides](https://gitlab.com/gitlab-org/gitlab-ee/blob/master/CONTRIBUTING.md#style-guides)
- [x] [Squashed related commits together](https://git-scm.com/book/en/Git-Tools-Rewriting-History#Squashing-Commits)
## What are the relevant issue numbers?10.1username-removed-128633username-removed-128633https://staging.gitlab.com/gitlab-org/gitlab/-/merge_requests/2979Sync dev to gitlab.com2017-09-21T05:37:48ZJarka Kadlecovajarka@gitlab.comSync dev to gitlab.comThe changelog is missing on gitlab.com but not on dev - this is a merge of dev master into gitlab.com masterThe changelog is missing on gitlab.com but not on dev - this is a merge of dev master into gitlab.com masterSimon KnoxSimon Knoxhttps://staging.gitlab.com/gitlab-org/gitlab/-/merge_requests/2965CE upstream - Wednesday2017-09-21T07:58:22Zusername-removed-128633CE upstream - WednesdayFiles to resolve:
- [x] `@jhurewitz` Please resolve https://gitlab.com/gitlab-org/gitlab-ee/blob/07ce00df3275b5c130b2e1fc2475a7f98fd2ac57/LICENSE (UU)
- [x] `@andrewn` Please resolve https://gitlab.com/gitlab-org/gitlab-ee/blob/07ce00df...Files to resolve:
- [x] `@jhurewitz` Please resolve https://gitlab.com/gitlab-org/gitlab-ee/blob/07ce00df3275b5c130b2e1fc2475a7f98fd2ac57/LICENSE (UU)
- [x] `@andrewn` Please resolve https://gitlab.com/gitlab-org/gitlab-ee/blob/07ce00df3275b5c130b2e1fc2475a7f98fd2ac57/app/controllers/projects/refs_controller.rb (UU)
- [x] `@madlittlemods` Please resolve https://gitlab.com/gitlab-org/gitlab-ee/blob/07ce00df3275b5c130b2e1fc2475a7f98fd2ac57/spec/javascripts/vue_mr_widget/stores/mr_widget_store_spec.js (UU)
- [x] `@grzesiek` Please resolve https://gitlab.com/gitlab-org/gitlab-ee/blob/07ce00df3275b5c130b2e1fc2475a7f98fd2ac57/spec/lib/gitlab/ci/yaml_processor_spec.rb (UU)
- [x] `@felipe_artur` Please resolve https://gitlab.com/gitlab-org/gitlab-ee/blob/07ce00df3275b5c130b2e1fc2475a7f98fd2ac57/spec/policies/project_policy_spec.rb (UU)
- [x] `@rymai` Please resolve https://gitlab.com/gitlab-org/gitlab-ee/blob/07ce00df3275b5c130b2e1fc2475a7f98fd2ac57/spec/requests/api/boards_spec.rb (UU)
- [x] `@rymai` Please resolve https://gitlab.com/gitlab-org/gitlab-ee/blob/07ce00df3275b5c130b2e1fc2475a7f98fd2ac57/spec/requests/api/v3/builds_spec.rb (UU)
Once the conflicts resolved, please push (no force-push!) to the `ce-to-ee-2017-09-20` branch.
Thanks in advance! ❤️
Note: This merge request was created by an experimental script, it's not perfect (yet)!username-removed-128633username-removed-128633https://staging.gitlab.com/gitlab-org/gitlab/-/merge_requests/2914Port of 37220-es-modules to EE2017-09-21T09:03:04ZFilipa Lacerdafilipa@gitlab.comPort of 37220-es-modules to EEPort of 37220-es-modules to EE https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/14074Port of 37220-es-modules to EE https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/1407410.1Phil Hughesme@iamphill.comPhil Hughesme@iamphill.comhttps://staging.gitlab.com/gitlab-org/gitlab/-/merge_requests/2760Can migrate LFS objects to S3 style object storage2017-09-21T09:55:56ZJames EJCan migrate LFS objects to S3 style object storage## What
- Allows LfsObjects to be individually migrated to object storage
- Reuses code from https://gitlab.com/gitlab-org/gitlab-ee/merge_requests/1762/diffs?diff_id=4841606#0ef14ca7e447f477230136ca76fb4ab0bed43af4
- Currently prov...## What
- Allows LfsObjects to be individually migrated to object storage
- Reuses code from https://gitlab.com/gitlab-org/gitlab-ee/merge_requests/1762/diffs?diff_id=4841606#0ef14ca7e447f477230136ca76fb4ab0bed43af4
- Currently provides a rake task for this in the same way as for artifacts, as well as scheduling a `ObjectStorageUploadWorker` automatically
## Why
Reduce space usage and load on git storage disks
## Todo
## Screenshots (if relevant)
## Acceptance criteria
- [x] [Changelog entry](https://docs.gitlab.com/ce/development/changelog.html) added, if necessary
- [ ] [Documentation created/updated](https://gitlab.com/gitlab-org/gitlab-ee/blob/master/doc/development/doc_styleguide.md)
- [ ] API support added
- [x] Tests added for this feature/bug
- [ ] Conform by the [merge request performance guides](http://docs.gitlab.com/ee/development/merge_request_performance_guidelines.html)
## Related
Fixes https://gitlab.com/gitlab-org/gitlab-ee/issues/284110.0Douwe MaanDouwe Maanhttps://staging.gitlab.com/gitlab-org/gitlab/-/merge_requests/2971Tighten up remove_old regex from gitlab backup manager.2017-09-21T12:04:47Zusername-removed-117638Tighten up remove_old regex from gitlab backup manager.EE Counterpart of https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/14333/commits#note_40858898
## Does this MR meet the acceptance criteria?
- [ ] [Changelog entry](https://docs.gitlab.com/ee/development/changelog.html) added, i...EE Counterpart of https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/14333/commits#note_40858898
## Does this MR meet the acceptance criteria?
- [ ] [Changelog entry](https://docs.gitlab.com/ee/development/changelog.html) added, if necessary
- [ ] [Documentation created/updated](https://docs.gitlab.com/ee/development/doc_styleguide.html)
- [ ] API support added
- [ ] Tests added for this feature/bug
- Review
- [ ] Has been reviewed by UX
- [ ] Has been reviewed by Frontend
- [ ] Has been reviewed by Backend
- [ ] Has been reviewed by Database
- [ ] Conform by the [merge request performance guides](https://docs.gitlab.com/ee/development/merge_request_performance_guidelines.html)
- [ ] Conform by the [style guides](https://gitlab.com/gitlab-org/gitlab-ee/blob/master/CONTRIBUTING.md#style-guides)
- [ ] [Squashed related commits together](https://git-scm.com/book/en/Git-Tools-Rewriting-History#Squashing-Commits)
## What are the relevant issue numbers?10.1username-removed-117638username-removed-117638https://staging.gitlab.com/gitlab-org/gitlab/-/merge_requests/2932fix the approvals_before_merge project fallback2017-09-21T12:53:27ZMicael Bergeronfix the approvals_before_merge project fallback## What does this MR do?
This fix #3142 by making sure we use the correct target_project when evaluating the approvals count.
## Are there points in the code the reviewer needs to double check?
The current tests are done using a refle...## What does this MR do?
This fix #3142 by making sure we use the correct target_project when evaluating the approvals count.
## Are there points in the code the reviewer needs to double check?
The current tests are done using a reflective MR (target_project == source_project), but I didn't find tests for
MR that target a fork. The current change complies with the current test, but extensive tests could be added.
## Why was this MR needed?
For a forked MR, the fallback project was always the project's fork, not the currently targeted project. This fixes
this.
## Does this MR meet the acceptance criteria?
- [x] [Changelog entry](https://docs.gitlab.com/ee/development/changelog.html) added, if necessary
- [x] [Documentation created/updated](https://docs.gitlab.com/ee/development/doc_styleguide.html)
- [ ] API support added
- [ ] Tests added for this feature/bug
- Review
- [ ] Has been reviewed by UX
- [ ] Has been reviewed by Frontend
- [ ] Has been reviewed by Backend
- [ ] Has been reviewed by Database
- [ ] Conform by the [merge request performance guides](https://docs.gitlab.com/ee/development/merge_request_performance_guidelines.html)
- [ ] Conform by the [style guides](https://gitlab.com/gitlab-org/gitlab-ee/blob/master/CONTRIBUTING.md#style-guides)
- [ ] [Squashed related commits together](https://git-scm.com/book/en/Git-Tools-Rewriting-History#Squashing-Commits)
## What are the relevant issue numbers?
Closes #314210.1Douwe MaanDouwe Maanhttps://staging.gitlab.com/gitlab-org/gitlab/-/merge_requests/2981CE upstream: Thursday2017-09-21T13:36:11ZNick ThomasCE upstream: Thursday- [x] both modified: CHANGELOG.md
- [x] both modified: Gemfile.lock
- [x] both modified: app/assets/javascripts/boards/stores/boards_store.js
- [x] both modified: app/assets/javascripts/dispatcher.js
- [x] both modified: app/as...- [x] both modified: CHANGELOG.md
- [x] both modified: Gemfile.lock
- [x] both modified: app/assets/javascripts/boards/stores/boards_store.js
- [x] both modified: app/assets/javascripts/dispatcher.js
- [x] both modified: app/assets/javascripts/environments/components/environment.vue10.1username-removed-128633username-removed-128633https://staging.gitlab.com/gitlab-org/gitlab/-/merge_requests/2988Document that group Owners can always create subgroups2017-09-21T14:15:40ZAchilleas PipinellisDocument that group Owners can always create subgroups## What does this MR do?
CE port https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/14416## What does this MR do?
CE port https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/1441610.1username-removed-236961username-removed-236961https://staging.gitlab.com/gitlab-org/gitlab/-/merge_requests/2963Update references to parseSeconds and stringifyTime in geo_nodes.2017-09-21T18:07:05Zusername-removed-408230Update references to parseSeconds and stringifyTime in geo_nodes.EE compatible application of changes in https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/14058
cc: @to1ne @ClemMakesApps @fatihacet EE compatible application of changes in https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/14058
cc: @to1ne @ClemMakesApps @fatihacet username-removed-502136username-removed-502136https://staging.gitlab.com/gitlab-org/gitlab/-/merge_requests/2957show project labels on group board cards2017-09-21T20:02:17ZSimon Knoxshow project labels on group board cards## What does this MR do?
remove filter for project labels - this was a missed requirement. Was added about the same time as this comment https://gitlab.com/gitlab-org/gitlab-ee/merge_requests/2467#note_38452577
## Does this MR meet t...## What does this MR do?
remove filter for project labels - this was a missed requirement. Was added about the same time as this comment https://gitlab.com/gitlab-org/gitlab-ee/merge_requests/2467#note_38452577
## Does this MR meet the acceptance criteria?
- [x] Tests added for this feature/bug
- Review
- [ ] Has been reviewed by Frontend
## What are the relevant issue numbers?
Closes #344110.0Phil Hughesme@iamphill.comPhil Hughesme@iamphill.comhttps://staging.gitlab.com/gitlab-org/gitlab/-/merge_requests/2989Auto DevOps docs cleanup2017-09-21T20:02:17ZAchilleas PipinellisAuto DevOps docs cleanup## What does this MR do?
CE port of https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/14293## What does this MR do?
CE port of https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/1429310.0username-removed-236961username-removed-236961https://staging.gitlab.com/gitlab-org/gitlab/-/merge_requests/2945Resolve "Burndown chart Banner shows up even if group has upgraded"2017-09-21T20:02:17ZTim ZallmannResolve "Burndown chart Banner shows up even if group has upgraded"## What does this MR do?
Fixes the promotion for the burndown chart and the default template to not show when you already have that feature.
## Does this MR meet the acceptance criteria?
- Review
- [ ] Has been reviewed by Ba...## What does this MR do?
Fixes the promotion for the burndown chart and the default template to not show when you already have that feature.
## Does this MR meet the acceptance criteria?
- Review
- [ ] Has been reviewed by Backend
- [ ] Conform by the [merge request performance guides](https://docs.gitlab.com/ee/development/merge_request_performance_guidelines.html)
- [ ] Conform by the [style guides](https://gitlab.com/gitlab-org/gitlab-ee/blob/master/CONTRIBUTING.md#style-guides)
- [ ] [Squashed related commits together](https://git-scm.com/book/en/Git-Tools-Rewriting-History#Squashing-Commits)
## What are the relevant issue numbers?
Closes #3471, #347410.0Douwe MaanDouwe Maanhttps://staging.gitlab.com/gitlab-org/gitlab/-/merge_requests/2969Resolve "Service Desk filter Error 500"2017-09-21T20:02:17ZNick ThomasResolve "Service Desk filter Error 500"## What does this MR do?
Fixes a NoMethodError caused by moving some code into the ::EE module in 9c2c1f3c
## Are there points in the code the reviewer needs to double check?
## Why was this MR needed?
Regression fix
## Screenshots ...## What does this MR do?
Fixes a NoMethodError caused by moving some code into the ::EE module in 9c2c1f3c
## Are there points in the code the reviewer needs to double check?
## Why was this MR needed?
Regression fix
## Screenshots (if relevant)
## Does this MR meet the acceptance criteria?
- [x] [Changelog entry](https://docs.gitlab.com/ee/development/changelog.html) added, if necessary
- [x] [Documentation created/updated](https://docs.gitlab.com/ee/development/doc_styleguide.html)
- [x] Tests added for this feature/bug
- Review
- [ ] Has been reviewed by Backend
- [x] Conform by the [merge request performance guides](https://docs.gitlab.com/ee/development/merge_request_performance_guidelines.html)
- [x] Conform by the [style guides](https://gitlab.com/gitlab-org/gitlab-ee/blob/master/CONTRIBUTING.md#style-guides)
- [x] [Squashed related commits together](https://git-scm.com/book/en/Git-Tools-Rewriting-History#Squashing-Commits)
## What are the relevant issue numbers?
Closes #348810.0Douwe MaanDouwe Maanhttps://staging.gitlab.com/gitlab-org/gitlab/-/merge_requests/2943Simplify specification of EE license/plan features2017-09-21T20:05:50ZDouwe MaanSimplify specification of EE license/plan featuresFixes https://gitlab.com/gitlab-org/gitlab-ee/issues/2466
/cc @to1ne @oswaldoFixes https://gitlab.com/gitlab-org/gitlab-ee/issues/2466
/cc @to1ne @oswaldo10.1username-removed-128633username-removed-128633