GitLab merge requestshttps://staging.gitlab.com/gitlab-org/gitlab/-/merge_requests2017-08-21T05:39:59Zhttps://staging.gitlab.com/gitlab-org/gitlab/-/merge_requests/2725Fixes Audit Events Documentation issue link2017-08-21T05:39:59Zusername-removed-419655Fixes Audit Events Documentation issue link## What does this MR do?
Fixes Audit Events Documentation issue link
## Does this MR meet the acceptance criteria?
- [ ] [Changelog entry](https://docs.gitlab.com/ce/development/changelog.html) added, if necessary
- [ ] [Documentation...## What does this MR do?
Fixes Audit Events Documentation issue link
## Does this MR meet the acceptance criteria?
- [ ] [Changelog entry](https://docs.gitlab.com/ce/development/changelog.html) added, if necessary
- [ ] [Documentation created/updated](https://gitlab.com/gitlab-org/gitlab-ee/blob/master/doc/development/doc_styleguide.md)
- [ ] API support added
- Tests
- [ ] Added for this feature/bug
- [ ] All builds are passing
- [ ] Conform by the [merge request performance guides](http://docs.gitlab.com/ee/development/merge_request_performance_guidelines.html)
- [ ] Conform by the [style guides](https://gitlab.com/gitlab-org/gitlab-ee/blob/master/CONTRIBUTING.md#style-guides)
- [ ] Branch has no merge conflicts with `master` (if it does - rebase it please)
- [ ] [Squashed related commits together](https://git-scm.com/book/en/Git-Tools-Rewriting-History#Squashing-Commits)10.0Achilleas PipinellisAchilleas Pipinellishttps://staging.gitlab.com/gitlab-org/gitlab/-/merge_requests/2724Refactor GPG docs2017-08-21T15:21:53ZAchilleas PipinellisRefactor GPG docs## What does this MR do?
Port of CE https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/13660## What does this MR do?
Port of CE https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/136609.5username-removed-236961username-removed-236961https://staging.gitlab.com/gitlab-org/gitlab/-/merge_requests/2723Fix testing of Jenkins integration2017-08-22T07:51:33ZRubén DávilaFix testing of Jenkins integration## What does this MR do?
Fix the testing of Jenkins integration that was broken due to we weren't creating the Service/ServiceHook records.
## Are there points in the code the reviewer needs to double check?
## Why was this MR needed?...## What does this MR do?
Fix the testing of Jenkins integration that was broken due to we weren't creating the Service/ServiceHook records.
## Are there points in the code the reviewer needs to double check?
## Why was this MR needed?
Users were unable to test their Jenkins integration
## Screenshots (if relevant)
## Does this MR meet the acceptance criteria?
- [ ] [Changelog entry](https://docs.gitlab.com/ce/development/changelog.html) added, if necessary
- [ ] [Documentation created/updated](https://gitlab.com/gitlab-org/gitlab-ee/blob/master/doc/development/doc_styleguide.md)
- [ ] API support added
- Tests
- [ ] Added for this feature/bug
- [ ] All builds are passing
- [ ] Conform by the [merge request performance guides](http://docs.gitlab.com/ee/development/merge_request_performance_guidelines.html)
- [ ] Conform by the [style guides](https://gitlab.com/gitlab-org/gitlab-ee/blob/master/CONTRIBUTING.md#style-guides)
- [ ] Branch has no merge conflicts with `master` (if it does - rebase it please)
- [ ] [Squashed related commits together](https://git-scm.com/book/en/Git-Tools-Rewriting-History#Squashing-Commits)
## What are the relevant issue numbers?
Closes #31949.5Douwe MaanDouwe Maanhttps://staging.gitlab.com/gitlab-org/gitlab/-/merge_requests/2722Log Geo file download attempts and status2017-08-22T19:07:43ZStan HuLog Geo file download attempts and statusAdds JSON logging for file downloads. For example:
```json
{"severity":"INFO","time":"2017-08-19T05:02:02.730Z","class":"Geo::FileDownloadService","object_type":"avatar","object_db_id":3,"message":"File download","success":true,"bytes_d...Adds JSON logging for file downloads. For example:
```json
{"severity":"INFO","time":"2017-08-19T05:02:02.730Z","class":"Geo::FileDownloadService","object_type":"avatar","object_db_id":3,"message":"File download","success":true,"bytes_downloaded":100,"download_time_s":0.001}
{"severity":"INFO","time":"2017-08-19T05:02:03.561Z","class":"Geo::FileDownloadService","object_type":"attachment","object_db_id":4,"message":"File download","success":true,"bytes_downloaded":100,"download_time_s":0.001}
{"severity":"INFO","time":"2017-08-19T05:02:03.993Z","class":"Geo::FileDownloadService","object_type":"file","object_db_id":5,"message":"File download","success":true,"bytes_downloaded":100,"download_time_s":0.001}
{"severity":"INFO","time":"2017-08-19T05:02:04.199Z","class":"Geo::FileDownloadService","object_type":"lfs","object_db_id":1,"message":"File download","success":true,"bytes_downloaded":100,"download_time_s":0.003}
```10.0Robert SpeicherRobert Speicherhttps://staging.gitlab.com/gitlab-org/gitlab/-/merge_requests/2721Log Geo update delay and download times of repository sync2017-08-24T20:29:47ZStan HuLog Geo update delay and download times of repository syncCloses #3020 Closes #3020 10.0Robert SpeicherRobert Speicherhttps://staging.gitlab.com/gitlab-org/gitlab/-/merge_requests/2720Sync ldap external groups on login2017-08-28T12:29:04Zusername-removed-1144264Sync ldap external groups on login## What does this MR do?
On LDAP login, the user's external flag is set by checking external groups immediately.
## Are there points in the code the reviewer needs to double check?
I would prefer to have at least one integration...## What does this MR do?
On LDAP login, the user's external flag is set by checking external groups immediately.
## Are there points in the code the reviewer needs to double check?
I would prefer to have at least one integration test for this, but I didn't see a good one that doesn't seem to stub as much as I'm already doing in these unit tests.
I don't know how slow it can be to pull member DNs for a group, but if there are a lot of `external_groups` with a lot of members, I imagine this could cause logins to be slow. I am currently unaware of a faster way to do it though.
## Why was this MR needed?
On customer installations with LDAP and external groups, new users that should be external could login and see everything until a scheduled sync worker ran.
## Does this MR meet the acceptance criteria?
- [x] [Changelog entry](https://docs.gitlab.com/ce/development/changelog.html) added, if necessary
- [ ] ~~[Documentation created/updated](https://gitlab.com/gitlab-org/gitlab-ee/blob/master/doc/development/doc_styleguide.md)~~
- [ ] ~~API support added~~
- Tests
- [x] Added for this feature/bug
- [ ] All builds are passing
- [x] Conform by the [merge request performance guides](http://docs.gitlab.com/ee/development/merge_request_performance_guidelines.html)
- [x] Conform by the [style guides](https://gitlab.com/gitlab-org/gitlab-ee/blob/master/CONTRIBUTING.md#style-guides)
- [x] Branch has no merge conflicts with `master` (if it does - rebase it please)
- [x] [Squashed related commits together](https://git-scm.com/book/en/Git-Tools-Rewriting-History#Squashing-Commits)
## What are the relevant issue numbers?
Closes https://gitlab.com/gitlab-org/gitlab-ee/issues/246810.0Douwe MaanDouwe Maanhttps://staging.gitlab.com/gitlab-org/gitlab/-/merge_requests/2719[EE] Greatly reduce test duration for git_access_spec2017-09-20T10:06:43ZRobert Speicher[EE] Greatly reduce test duration for git_access_specEE version of https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/13675
This spec is slow -- 20+ minutes on CI. Numbers below are local.
### Baseline
```
Factory usage counts:
name total avg coun...EE version of https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/13675
This spec is slow -- 20+ minutes on CI. Numbers below are local.
### Baseline
```
Factory usage counts:
name total avg count
project-repository 121.871 0.116 1049
user 78.694 0.031 2569
merge_request 60.41 0.135 448
namespace 40.125 0.038 1065
protected_branch 3.396 0.008 432
group 2.442 0.013 192
Finished in 12 minutes 10 seconds (files took 15.44 seconds to load)
1067 examples, 0 failures
```
### Post cherry-pick of https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/13675
```
Factory usage counts:
name total avg count
project-repository 36.574 0.108 338
merge_request 22.779 0.136 168
user 20.53 0.028 746
namespace 12.03 0.034 354
group 2.455 0.013 192
deploy_key 1.825 0.13 14
protected_branch 1.608 0.007 222
Finished in 3 minutes 51.1 seconds (files took 14.22 seconds to load)
356 examples, 0 failures
```
### Refactor `run_group_permission_checks`
This uses the same thinking as the earlier `run_permission_checks`
refactor, to run all of the checks for the matrix in a single `it` block
to avoid repeated setup.
```
Factory usage counts:
name total avg count
project-repository 19.041 0.112 170
user 8.969 0.03 298
merge_request 7.754 0.138 56
namespace 6.641 0.036 186
Finished in 1 minute 44.65 seconds (files took 0.91818 seconds to load)
188 examples, 0 failures
```
:tada:
### Fix invalid GitAccess specs for License and secondary Geo node
Due to a logic error, these specs weren't actually doing anything -- we
were running the checks on `Hash.new(Hash.new(false))`, which is just
`{}`.
### Refactor `push_rule_check` GitAccess specs
- Reduces duplication of long ref strings
- Passes push rule attributes directly to `create_push_rule`, rather
than creating one and then updating it.9.5Douwe MaanDouwe Maanhttps://staging.gitlab.com/gitlab-org/gitlab/-/merge_requests/2718WIP: [skip ci] add feature highlight2017-08-21T19:43:12Zusername-removed-408677WIP: [skip ci] add feature highlight## What does this MR do?
## Are there points in the code the reviewer needs to double check?
## Why was this MR needed?
## Screenshots (if relevant)
## Does this MR meet the acceptance criteria?
- [ ] [Changelog entry](htt...## What does this MR do?
## Are there points in the code the reviewer needs to double check?
## Why was this MR needed?
## Screenshots (if relevant)
## Does this MR meet the acceptance criteria?
- [ ] [Changelog entry](https://docs.gitlab.com/ce/development/changelog.html) added, if necessary
- [ ] [Documentation created/updated](https://gitlab.com/gitlab-org/gitlab-ee/blob/master/doc/development/doc_styleguide.md)
- [ ] API support added
- Tests
- [ ] Added for this feature/bug
- [ ] All builds are passing
- [ ] Conform by the [merge request performance guides](http://docs.gitlab.com/ee/development/merge_request_performance_guidelines.html)
- [ ] Conform by the [style guides](https://gitlab.com/gitlab-org/gitlab-ee/blob/master/CONTRIBUTING.md#style-guides)
- [ ] Branch has no merge conflicts with `master` (if it does - rebase it please)
- [ ] [Squashed related commits together](https://git-scm.com/book/en/Git-Tools-Rewriting-History#Squashing-Commits)
## What are the relevant issue numbers?
Closes https://gitlab.com/gitlab-org/gitlab-ce/issues/36760https://staging.gitlab.com/gitlab-org/gitlab/-/merge_requests/2717Fixes the stable branches sidebar navigation2017-09-14T01:04:07ZPhil Hughesme@iamphill.comFixes the stable branches sidebar navigation## What does this MR do?
Fixes the 9.5 stable branch sidebar navigation## What does this MR do?
Fixes the 9.5 stable branch sidebar navigation9.5Tim ZallmannTim Zallmannhttps://staging.gitlab.com/gitlab-org/gitlab/-/merge_requests/2716Docs: update links guideline to inline links2017-08-25T15:30:51Zusername-removed-236961Docs: update links guideline to inline linksSee the general Documentation guidelines http://docs.gitlab.com/ce/development/doc_styleguide.html
## What does this MR do?
Port from CE: https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/13677See the general Documentation guidelines http://docs.gitlab.com/ce/development/doc_styleguide.html
## What does this MR do?
Port from CE: https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/1367710.0Achilleas PipinellisAchilleas Pipinellishttps://staging.gitlab.com/gitlab-org/gitlab/-/merge_requests/2715Move "Move issue" to sidebar - EE merge edition2017-09-04T09:32:08Zusername-removed-892863contact@ericeastwood.comMove "Move issue" to sidebar - EE merge editionEE merge edition of https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/13616
Also cherry-picked the following because it hasn't made it to EE
- https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/13436
- https://gitlab.co...EE merge edition of https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/13616
Also cherry-picked the following because it hasn't made it to EE
- https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/13436
- https://gitlab.com/gitlab-org/gitlab-ce/commit/7cc19cd5abb4ae8649e960c71d531adccb880a8910.0Phil Hughesme@iamphill.comPhil Hughesme@iamphill.comhttps://staging.gitlab.com/gitlab-org/gitlab/-/merge_requests/2714Drop unnecessary timestamp columns in Geo event tables2017-09-26T11:32:41Zusername-removed-283999douglas@gitlab.comDrop unnecessary timestamp columns in Geo event tablesDrop unnecessary timestamp columns in Geo event tables.
## Database Checklist
When removing columns, tables, indexes or other structures:
- [ ] ~~Removed these in a post-deployment migration~~
- [x] Made sure the application no longer...Drop unnecessary timestamp columns in Geo event tables.
## Database Checklist
When removing columns, tables, indexes or other structures:
- [ ] ~~Removed these in a post-deployment migration~~
- [x] Made sure the application no longer uses (or ignores) these structures
## General Checklist
- [ ] ~~[Changelog entry](https://docs.gitlab.com/ce/development/changelog.html) added, if necessary~~
- [ ] ~~[Documentation created/updated](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/doc/development/doc_styleguide.md)~~
- [ ] ~~API support added~~
- [ ] ~~Tests added for this feature/bug~~
- Review
- [ ] Has been reviewed by Backend
- [ ] Has been reviewed by Database
- [x] Conform by the [merge request performance guides](http://docs.gitlab.com/ce/development/merge_request_performance_guidelines.html)
- [x] Conform by the [style guides](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/CONTRIBUTING.md#style-guides)
- [ ] [Squashed related commits together](https://git-scm.com/book/en/Git-Tools-Rewriting-History#Squashing-Commits)10.0Robert SpeicherRobert Speicherhttps://staging.gitlab.com/gitlab-org/gitlab/-/merge_requests/2713Implement new EE-only system note icons2017-08-22T19:44:19Zusername-removed-408230Implement new EE-only system note icons## All changed icons
### approved/unapproved
![Screen_Shot_2017-08-18_at_4.47.22_PM](/uploads/f4e998c22f75ba2117dab8a90877b823/Screen_Shot_2017-08-18_at_4.47.22_PM.png)
### unrelated/related
![Screen_Shot_2017-08-18_at_4.40.31_PM...## All changed icons
### approved/unapproved
![Screen_Shot_2017-08-18_at_4.47.22_PM](/uploads/f4e998c22f75ba2117dab8a90877b823/Screen_Shot_2017-08-18_at_4.47.22_PM.png)
### unrelated/related
![Screen_Shot_2017-08-18_at_4.40.31_PM](/uploads/19bc10d77750a4c161a3d75c422330d3/Screen_Shot_2017-08-18_at_4.40.31_PM.png)
## What are the relevant issue numbers?
Closes #3205 10.0username-removed-408677username-removed-408677https://staging.gitlab.com/gitlab-org/gitlab/-/merge_requests/2712WIP: Prepare 9.5.0 RC6 EE2017-09-14T01:04:08ZJose Ivan Vargas LopezWIP: Prepare 9.5.0 RC6 EEMain release issue: https://gitlab.com/gitlab-org/gitlab-ce/issues/36157
### Summary
This MR prepares `9-5-stable-ee` for %"9.5" (`RC5`)`by merging`9-5-stable-ee-prepare-RC5`into`9-5-stable-ee`
### MR Filter for ~"Pick into Stable" MR...Main release issue: https://gitlab.com/gitlab-org/gitlab-ce/issues/36157
### Summary
This MR prepares `9-5-stable-ee` for %"9.5" (`RC5`)`by merging`9-5-stable-ee-prepare-RC5`into`9-5-stable-ee`
### MR Filter for ~"Pick into Stable" MRs
https://gitlab.com/gitlab-org/gitlab-ee/merge_requests?label_name%5B%5D=Pick+into+Stable&milestone_title=9-5&scope=all&sort=updated_asc&state=merged
### Steps
- Ensure all the MRs in the list above are picked into `9-5-stable-ee-prepare-RC5` branch.
- Note the following in each picked MR:
```
Picked into https://gitlab.com/gitlab-org/gitlab-ee/merge_requests/2698, will merge into `9-5-stable-ee` ready for `9.5 RC5`
/unlabel ~"Pick into Stable"
```
- If there are any conflicts while picking MRs then attempt to resolve them; otherwise, create a new MR against the `9-5-stable-prepare-rc5` branch and assign it to the author of the conflicting files.
- Merge CE-to-EE using one of the workflows described in the [Merge CE stable changes to EE docs](https://gitlab.com/gitlab-org/release-tools/blob/master/doc/picking-into-merge-requests.md#merge-ce-stable-changes-to-ee)
- Once this MR is green merge it.https://staging.gitlab.com/gitlab-org/gitlab/-/merge_requests/2711Make issuable filter dropdown style consistent2017-08-18T23:07:36ZWinnie HellmannMake issuable filter dropdown style consistentThis is the same as https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/13421.
## What does this MR do?
Change dropdowns in issuable search bar to new style.
This affects the following pages:
- [issue list](https://gitlab....This is the same as https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/13421.
## What does this MR do?
Change dropdowns in issuable search bar to new style.
This affects the following pages:
- [issue list](https://gitlab.com/gitlab-org/gitlab-ce/issues)
- [issue boards](https://gitlab.com/gitlab-org/gitlab-ce/boards)
- [merge request list](https://gitlab.com/gitlab-org/gitlab-ce/merge_requests)
- [group issue list](https://gitlab.com/groups/gitlab-org/issues)
## Screenshots
| Before | After |
| --- | --- |
| ![Screen_Shot_2017-08-09_at_13.19.26](https://gitlab.com/gitlab-org/gitlab-ce/uploads/411bf60756d2149066ee1c7be795d206/Screen_Shot_2017-08-09_at_13.19.26.png) | ![Screen_Shot_2017-08-09_at_13.19.35](https://gitlab.com/gitlab-org/gitlab-ce/uploads/636bda673225b007d6479b78bcdadd3d/Screen_Shot_2017-08-09_at_13.19.35.png) |
| ![Screen_Shot_2017-08-09_at_13.20.44](https://gitlab.com/gitlab-org/gitlab-ce/uploads/d1f3543e83b8f308a2ab8d5d21a9513a/Screen_Shot_2017-08-09_at_13.20.44.png) | ![Screen_Shot_2017-08-09_at_13.45.19](https://gitlab.com/gitlab-org/gitlab-ce/uploads/92da9f80def168fd14a2a5477a683597/Screen_Shot_2017-08-09_at_13.45.19.png) |
| ![Screen_Shot_2017-08-09_at_13.21.27](https://gitlab.com/gitlab-org/gitlab-ce/uploads/49186647281bf15f3cda1ae59bd64738/Screen_Shot_2017-08-09_at_13.21.27.png) | ![Screen_Shot_2017-08-09_at_13.45.28](/uploads/676996a70484da300395e0db0308f0f8/Screen_Shot_2017-08-09_at_13.45.28.png) |
| ![Screen_Shot_2017-08-09_at_13.49.35](https://gitlab.com/gitlab-org/gitlab-ce/uploads/e97f2f01a0fe21524d94896622d59f62/Screen_Shot_2017-08-09_at_13.49.35.png) | ![Screen_Shot_2017-08-09_at_13.49.17](/uploads/1f7be2f012cb66b38206dae188b83e29/Screen_Shot_2017-08-09_at_13.49.17.png) |
| ![Screen_Shot_2017-08-09_at_13.50.48](https://gitlab.com/gitlab-org/gitlab-ce/uploads/04a76e3ccfdb5fdf37c0b1c871c64f31/Screen_Shot_2017-08-09_at_13.50.48.png) | ![Screen_Shot_2017-08-09_at_13.51.14](https://gitlab.com/gitlab-org/gitlab-ce/uploads/45094d51e57fe7d8480d4b18d7e4bc7b/Screen_Shot_2017-08-09_at_13.51.14.png) |
## What are the relevant issue numbers?
gitlab-ce#28921, gitlab-ce#3542410.0username-removed-408677username-removed-408677https://staging.gitlab.com/gitlab-org/gitlab/-/merge_requests/2710CE upstream: Friday2017-08-22T06:32:54Zusername-removed-423915CE upstream: FridayForgot to record the conflicting files, but the resolution is at https://gitlab.com/gitlab-org/gitlab-ee/commit/2c8e9ac18ee9563fe58129bbbc1037ff575c9287Forgot to record the conflicting files, but the resolution is at https://gitlab.com/gitlab-org/gitlab-ee/commit/2c8e9ac18ee9563fe58129bbbc1037ff575c928710.0Valery SizovValery Sizovhttps://staging.gitlab.com/gitlab-org/gitlab/-/merge_requests/2709Fix advanced search syntax for commits2017-08-22T12:53:20ZNick ThomasFix advanced search syntax for commits## What does this MR do?
The introduction of advanced search syntax allowed queries like `-foo`. These break our repository queries in two distinct ways:
* Blobs would be returned for commit queries, and vice-versa
* Highlighting was a...## What does this MR do?
The introduction of advanced search syntax allowed queries like `-foo`. These break our repository queries in two distinct ways:
* Blobs would be returned for commit queries, and vice-versa
* Highlighting was assumed to be present for all queries
The first is fixed by adding explicit type terms to the queries:
```ruby
{ term: { 'commit.type' => 'commit' } }
{ term: { 'blob.type' => 'blob' } }
```
(The `_type` field is, of course, `repository` for both document kinds).
A query matched by a negative search will not have any highlighting results, so we also need to make processing that conditional.
Finally, switch commit search to `default_operator: :and` so it behaves more like the rest of the application.
## Are there points in the code the reviewer needs to double check?
## Why was this MR needed?
Fix `NoMethodError` exceptions when performing searches with negation
## Screenshots (if relevant)
## Does this MR meet the acceptance criteria?
- [x] [Changelog entry](https://docs.gitlab.com/ce/development/changelog.html) added, if necessary
- [ ] [Documentation created/updated](https://gitlab.com/gitlab-org/gitlab-ee/blob/master/doc/development/doc_styleguide.md)
- [ ] API support added
- Tests
- [x] Added for this feature/bug
- [x] All builds are passing
- [x] Conform by the [merge request performance guides](http://docs.gitlab.com/ee/development/merge_request_performance_guidelines.html)
- [x] Conform by the [style guides](https://gitlab.com/gitlab-org/gitlab-ee/blob/master/CONTRIBUTING.md#style-guides)
- [x] Branch has no merge conflicts with `master` (if it does - rebase it please)
- [x] [Squashed related commits together](https://git-scm.com/book/en/Git-Tools-Rewriting-History#Squashing-Commits)
## What are the relevant issue numbers?
Closes #301110.0username-removed-443319username-removed-443319https://staging.gitlab.com/gitlab-org/gitlab/-/merge_requests/2708Document how to use AWS IAM profiles for object storage2017-08-18T17:29:25ZStan HuDocument how to use AWS IAM profiles for object storageDue to https://github.com/fog/fog-aws/issues/162, fog-aws requires a blank AWS access key and ID to make IAM profiles work with object storage.Due to https://github.com/fog/fog-aws/issues/162, fog-aws requires a blank AWS access key and ID to make IAM profiles work with object storage.9.5Achilleas PipinellisAchilleas Pipinellishttps://staging.gitlab.com/gitlab-org/gitlab/-/merge_requests/2707Hijack ActiveRecord::Base.connection in the DB load balancer2017-08-22T18:37:11Zyorickpeterse-stagingHijack ActiveRecord::Base.connection in the DB load balancer## What does this MR do?
This updates the DB load balancing code so we ensure that _all_ queries, even those using `ActiveRecord::Base.connection` directly, go through the load balancer.
## Are there points in the code the reviewer nee...## What does this MR do?
This updates the DB load balancing code so we ensure that _all_ queries, even those using `ActiveRecord::Base.connection` directly, go through the load balancer.
## Are there points in the code the reviewer needs to double check?
## Why was this MR needed?
Rails internals use `ActiveRecord::Base.connection` directly in various places. This means that the primary going down can lead to application errors.
## Does this MR meet the acceptance criteria?
- [x] [Changelog entry](https://docs.gitlab.com/ce/development/changelog.html) added, if necessary
- Tests
- [x] Added for this feature/bug
- [x] Conform by the [merge request performance guides](http://docs.gitlab.com/ee/development/merge_request_performance_guidelines.html)
- [x] Conform by the [style guides](https://gitlab.com/gitlab-org/gitlab-ee/blob/master/CONTRIBUTING.md#style-guides)
- [x] [Squashed related commits together](https://git-scm.com/book/en/Git-Tools-Rewriting-History#Squashing-Commits)
## What are the relevant issue numbers?
https://gitlab.com/gitlab-org/gitlab-ee/issues/31919.5username-removed-443319username-removed-443319https://staging.gitlab.com/gitlab-org/gitlab/-/merge_requests/2706Make mirror user dropdown in project settings consistent2017-09-05T07:55:42ZWinnie HellmannMake mirror user dropdown in project settings consistent## What does this MR do?
Change the mirror user dropdown in project repository settings to new style.
## Screenshots
| Before | After |
| --- | --- |
| ![Screen_Shot_2017-08-17_at_12.49.23](/uploads/a07aeed3fc9e5e8594329f013b0...## What does this MR do?
Change the mirror user dropdown in project repository settings to new style.
## Screenshots
| Before | After |
| --- | --- |
| ![Screen_Shot_2017-08-17_at_12.49.23](/uploads/a07aeed3fc9e5e8594329f013b04eb6b/Screen_Shot_2017-08-17_at_12.49.23.png) | ![Screen_Shot_2017-08-17_at_12.53.41](/uploads/cffac4dc7d12f959e8790aaecc4a293c/Screen_Shot_2017-08-17_at_12.53.41.png) |
## What are the relevant issue numbers?
https://gitlab.com/gitlab-org/gitlab-ce/issues/28921, https://gitlab.com/gitlab-org/gitlab-ce/issues/35424Phil Hughesme@iamphill.comPhil Hughesme@iamphill.com