CE -> EE port: cleanup application settings spec ee
What does this MR do?
It ports the changes of gitlab-org/gitlab-ce!10189 to EE.
Are there points in the code the reviewer needs to double check?
Ensure the changes in ApplicationSettings::UpdateService are correct.
Why was this MR needed?
In 9-0-stable some conflicts are resolved, but not very clean. This will clean this up. See https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/10070#note_25898584
Does this MR meet the acceptance criteria?
-
Changelog entry added, if necessary -
Documentation created/updated -
API support added - Tests
-
Added for this feature/bug -
All builds are passing
-
-
Conform by the merge request performance guides -
Conform by the style guides -
Branch has no merge conflicts with master(if it does - rebase it please) -
Squashed related commits together