Skip to content

Resolve "Number of required approvals MUST NOT be reset when changing assignee"

What does this MR do?

Don't reset the approval count set on an MR when it's higher than the project default, and we're not passing an approvals_before_merge param.

Are there points in the code the reviewer needs to double check?

Don't think so.

Why was this MR needed?

It was a bug! If the param isn't passed, we don't need to do the whole dance with clamping it.

Screenshots (if relevant)

Approval_count

Does this MR meet the acceptance criteria?

What are the relevant issue numbers?

Closes #1961 (closed).

Merge request reports