Create a push rule to check branch name

What does this MR do?

It creates a new push rule to check the branch name

Are there points in the code the reviewer needs to double check?

Don't think so, but it is my first contribution, so everything :)

Why was this MR needed?

At work we heavily use Gitlab and Gitlab CI (\o/) and we have a strictly policy for branch names (actually, for the beginning of the name) because we have different Gitlab CI jobs (feature / hotfix / docker / android etc etc) and I am tired to have to remember which names are allowed and which not

Does this MR meet the acceptance criteria?

• Changelog entry added, if necessary
• Documentation created/updated
• API support added
• Tests
  • Added for this feature/bug
  • All builds are passing
• Conform by the merge request performance guides
• Conform by the style guides
• Branch has no merge conflicts with master (if it does - rebase it please)
• Squashed related commits together

What are the relevant issue numbers?

Fixes #2293 (closed)

added 3 commits

• 0812789f - 2293: Implement push rule to check branch name
• 98647aef - 2293: Update the DB schema to add a push rule for branch name
• b0560b85 - Add changelog entry

Compare with previous version

marked the checklist item Changelog entry added, if necessary as completed

added 1 commit

• 2f944193 - Fix schema definition

Compare with previous version

added 1 commit

• 801078bb - Update schema.rb - fix version

Compare with previous version

added 2 commits

• 6ce0e7dc - 2293: Update the DB schema to add a push rule for branch name
• db1c3dc7 - Add changelog entry

Compare with previous version

marked the checklist item All builds are passing as completed

added 1473 commits

• db1c3dc7...cc3e7a47 - 1468 commits from branch gitlab-org:master
• 98647aef - 2293: Update the DB schema to add a push rule for branch name
• b0560b85 - Add changelog entry
• 2f944193 - Fix schema definition
• e58185ff - Merge remote-tracking branch 'origin/feature/2293-branch-name-push-rule' into fe…
• 01c9a678 - Merge branch 'master' into feature/2293-branch-name-push-rule

Compare with previous version

@rpadovani Thank you for your contribution, I will review it.

assigned to @rymai

added Community Contribution label

@rpadovani I had a few suggestions, please also update the image at doc/push_rules/push_rules.png.

assigned to @rpadovani

@rymai thanks for your review and the patience with my beginner's errors.

I fixed what you indicated and updated the image as well :-) Let me know if there is something else needed.

resolved all discussions

changed milestone to %9.3

thanks for your review and the patience with my beginner's errors.

@rpadovani That was really good already!

Thanks, looks good to me!

assigned to @rymai

approved this merge request

mentioned in commit eae6778a

merged

mentioned in issue #608 (closed)