Skip to content

Add optional sha parameter when approving an MR through the API

username-removed-443319 requested to merge add-sha-check-to-approvals-api into master

What does this MR do?

Add a sha parameter to the approvals API, so customers can ensure that they aren't approving the wrong version of an MR.

Are there points in the code the reviewer needs to double check?

I don't think so.

Why was this MR needed?

This works exactly like the same param when merging an MR.

We don't need this in the UI, because you already get a warning in the widget when the source branch HEAD changes while you're on the page.

Does this MR meet the acceptance criteria?

What are the relevant issue numbers?


Merge request reports