Hide geo completely when unlicensed

What does this MR do?

Removes Geo from the admin panel completely when unlicensed

Are there points in the code the reviewer needs to double check?

Why was this MR needed?

Context in #2335 (closed)

Screenshots (if relevant)

Does this MR meet the acceptance criteria?

• Changelog entry added, if necessary
• Documentation created/updated
• API support added
• Tests
  • Added for this feature/bug
  • All builds are passing
• Conform by the merge request performance guides
• Conform by the style guides
• Branch has no merge conflicts with master (if it does - rebase it please)
• Squashed related commits together

What are the relevant issue numbers?

mentioned in merge request !2266 (merged)

added 334 commits

• b9569bb5...ac030f24 - 333 commits from branch gitlab-org:master
• 5fa8d474 - Hide geo completely when unlicensed

Compare with previous version

Hi @nick.thomas. I remember many time ago the decision not to hide Geo from the Admin UI for "Marketing" reasons. So people will discover the feature and they can be redirect to a landing page etc. Don't know if this has changed or not, but just want to let you know why we didn't hide it from the beginning.

Also index and destroy ignores the license check in the controller so users who downgrade can still remove an existing Geo Node they forgot previously after the downgrade. See https://gitlab.com/gitlab-org/gitlab-ee/issues/788

Not all reasons are still valid from that, but we have things like credentials we add for the nodes users will want to remove

@brodock I agree, it's quite possible we do want to keep these actions. I just created this MR in case we decide not.

@mydigitalself What should we do here?

@DouweM I don't mind if it appears in the Admin UI. We can add it to the scope of https://gitlab.com/gitlab-org/gitlab-ee/issues/2624 to "Promote" it when you don't have the correct license cc @hazelyang

@mydigitalself All right, let's close this then!

closed

mentioned in issue #2846 (closed)