Future proof migration spec from irrelevant failures

What does this MR do?

Future proofs this migration spec from irrelevant failures.

Why was this MR needed?

The ApplicationSetting model was changed in CE, which broke this migration spec in EE.

Does this MR meet the acceptance criteria?

• Changelog entry added, if necessary
• Documentation created/updated
• API support added
• Tests
  • Added for this feature/bug
  • All builds are passing
• Conform by the [merge request performance guides](http://docs.gitlab.com/ee/development/merge_request_performance_guidelines.html)
• Conform by the style guides
• Branch has no merge conflicts with master (if it does - rebase it please)
• Squashed related commits together

What are the relevant issue numbers?

Closes https://gitlab.com/gitlab-org/gitlab-ee/issues/3102

assigned to @DouweM

@mkozono thanks! We could also fix this by defining the model local to the migration, as the migration spec will use the DB state as-of the time of the migration, but this works too!

changed milestone to %10.0

assigned to @smcgivern

assigned to @mkozono

added 1 commit

• bf057172 - Define model in migration spec

Compare with previous version

resolved all discussions

resolved all discussions

assigned to @smcgivern

marked the checklist item All builds are passing as completed

marked the checklist item All builds are passing as incomplete

changed title from Remove model usages from migration spec to Future proof migration spec from irrelevant failures

changed the description

resolved all discussions

assigned to @mkozono

resolved all discussions

added 1 commit

• db96561e - Use migration-defined-model

Compare with previous version

assigned to @smcgivern

Fewer lines of code in each iteration, that's how I like my MRs

Thanks for putting up with me @mkozono!

approved this merge request

merged

mentioned in commit 0d88bc8e