fix creating labels from Group Boards sidebar
2 unresolved threads
2 unresolved threads
What does this MR do?
Fix namespace_path for Group Boards sidebar
Are there points in the code the reviewer needs to double check?
Does this MR meet the acceptance criteria?
- Tests
-
Added for this feature/bug -
All builds are passing
-
-
Conform by the merge request performance guides -
Conform by the style guides -
Branch has no merge conflicts with master
(if it does - rebase it please) -
Squashed related commits together
What are the relevant issue numbers?
Closes #3369
Merge request reports
Activity
thanks for taking care of this @psimyn
@felipe_artur I've added a feature spec. Can you please review?
assigned to @felipe_artur
- spec/support/board_helpers.rb 0 → 100644
5 6 let(:user) { create(:user) } 7 let(:group) { create(:group, :public) } 8 let(:project) { create(:project, :public, namespace: group) } 9 let(:board) { create(:board, group: group) } 10 let!(:development) { create(:label, project: project, name: 'Development') } 11 let!(:issue) { create(:labeled_issue, project: project, labels: [development]) } 12 let!(:list) { create(:list, board: board, label: development, position: 0) } 13 14 before do 15 stub_licensed_features(group_issue_boards: true) 16 group.add_master(user) 17 18 sign_in(user) 19 20 visit group_boards_path(group) @psimyn Do we already have a spec that tests the same thing for project boards?
Thanks @psimyn Just a small question, also
do we need a CE backport?assigned to @psimyn
@felipe_artur this does need backport, created https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/14505
should that test be a shared example instead?
@psimyn Don't think so, just creating the same on CE version for projects should be enough.
Edited by Felipe Arturmentioned in commit bdbe892e
Please register or sign in to reply