Skip to content
Snippets Groups Projects

CE upstream

Merged CE upstream
ce_upstream into master
Merged Valery Sizov requested to merge ce_upstream into master
Viewing commit 509910b8
Prev Next
Show latest version
11 files
+ 251
− 51
Compare changes
  • Side-by-side
  • Inline
Files
11
  • 509910b8
    Yorick Peterse
    Process commits in a separate worker · 509910b8
    Yorick Peterse authored 
    This moves the code used for processing commits from GitPushService to
its own Sidekiq worker: ProcessCommitWorker.

Using a Sidekiq worker allows us to process multiple commits in
parallel. This in turn will lead to issues being closed faster and cross
references being created faster. Furthermore by isolating this code into
a separate class it's easier to test and maintain the code.

The new worker also ensures it can efficiently check which issues can be
closed, without having to run numerous SQL queries for every issue.
app/models/issue_collection.rb
+ 2
− 0
@@ -32,6 +32,8 @@ def updatable_by_user(user)
end
end
alias_method :visible_to, :updatable_by_user
private
def project_ids