Search bar first iteration ee

@smcgivern and @jschatz1 can you review? There is just a small change from (https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/7345) so that we have weight filters as part of the search bar filters

added 1 commit

12857491 - Add filtered search from CE

Compare with previous version

added 1 commit

a3158565 - Add filtered search from CE

Compare with previous version

added 1 commit

647e91a0 - Add filtered search from CE

Compare with previous version

added 1 commit

9e340090 - Add filtered search from CE

Compare with previous version

added 1 commit

e71aa6ef - Add weight filter

Compare with previous version

added 1 commit

fd140ebf - Add weight filter

Compare with previous version

assigned to @smcgivern

added 1 commit

e7da0186 - Add weight filter

Compare with previous version

@ClemMakesApps LGTM, just a couple of questions.

assigned to @ClemMakesApps

@ClemMakesApps @jschatz1 also note that in general we shouldn't merge the CE MR until the EE MR is ready to go. If this MR has issues that stop it from being merged, and there are merge conflicts, then this will hold up the CE -> EE merge, which can also block RCs.

That isn't the case here, but I just wanted to make that clear - something isn't done until it's in both CE and EE

See https://gitlab.slack.com/archives/core/p1483981149001672 for more info.

Actually, this did cause a (small) problem with the CE -> EE merge in https://gitlab.com/gitlab-org/gitlab-ee/merge_requests/1054, because spec/features/issues/filter_by_weight_spec.rb needs to be deleted. We'll remove it there, but that means RC2 for EE won't have this feature working properly, because the MRs weren't merged together.

@smcgivern Ops, my bad. Will merge EE first next time

I just realized that weight filters also included the following options (Everything and Any Weight) that are not in this MR as of yet. Based on my initial investigation, it looks like Everything will return all issues while Any Weight returns issues with weight (which is opposite to what the other Any filters do).

@victorwu @awhildy @cperessini can you let me know which one of those options we should add and what should we call them? If the functionality described above from my initial investigation is correct, I suggest we only keep Any Weight since the Everything option is redundant (same as not selecting that filter). Any Weight should be the same as weight:any. WDYT?

added 1 commit

08a6be77 - Add weight filter

Compare with previous version

Also, does anyone know if weight filters are used anywhere else besides the issues page?

Edit: looks like it's not being used elsewhere, so I've removed some old code.

I also noticed that the weight filters don't filter as you type (because the data is not received from json). Shouldn't be too difficult to add but I will leave that for next iteration (#1523 (closed))