Skip to content
Snippets Groups Projects
  1. Oct 28, 2016
  2. Oct 27, 2016
  3. Oct 25, 2016
    • Alejandro Rodríguez's avatar
      Refactor Ref's `target` to be consistent with Rugged · 43f5700b
      Alejandro Rodríguez authored
      !103 introduced an optimization where a Refs target would point to the
      dereferenced object, which saved us a lot operations, but became
      inconsistent with Rugged's API, where target would always reference the
      immediate object pointed at. These changes add a new property,
      dereference_target to be consistent with Rugged but still be able to get
      the target efficiently.
      43f5700b
  4. Oct 24, 2016
    • Douwe Maan's avatar
      Merge branch '31-diff-collapsing-changed-in-10-6-9' into 'master' · 382275e1
      Douwe Maan authored
      Revert to previous diff pruning behavior
      
      Before 10.6.9, if a rugged diff met the conditions for being too-large
      (which obiously meant it was also collapsable), too-large would take
      precedence. This reverts the behavior back to that, since gitlab-ce
      depends on this
      
      Closes #31
      
      See merge request !132
      382275e1
  5. Oct 21, 2016
  6. Oct 12, 2016
  7. Oct 10, 2016
  8. Oct 07, 2016
  9. Oct 03, 2016
    • Douwe Maan's avatar
      Merge branch 'rs-be_valid_commit-matcher' into 'master' · 08984b77
      Douwe Maan authored
      Fix invalid `be_valid_commit` matcher
      
      This matcher could have theoretically evaluated to the following:
      
      ```ruby
      true
      false
      true
      true
      ```
      
      ...and never would have caused a failure. Indeed, it should have been
      failing for quite a while.
      
      See merge request !126
      08984b77
  10. Oct 02, 2016
    • Robert Speicher's avatar
      Fix invalid `be_valid_commit` matcher · 80e3a7a5
      Robert Speicher authored
      This matcher could have theoretically evaluated to the following:
      
      ```ruby
      true
      false
      true
      true
      ```
      
      ...and never would have caused a failure. Indeed, it should have been
      failing for quite a while.
      80e3a7a5
  11. Sep 29, 2016
  12. Sep 23, 2016
  13. Sep 22, 2016
  14. Sep 14, 2016
  15. Sep 12, 2016
  16. Sep 10, 2016
  17. Sep 09, 2016
  18. Sep 08, 2016
    • Douwe Maan's avatar
      Merge branch 'mark-blobs-binary' into 'master' · 43cc7189
      Douwe Maan authored
      Mark blobs as binary whenever this is known
      
      This removes the need for using `Linguist::BlobHelper#binary?` whenever the binary status is already known, in turn reducing loading times of https://gitlab.com/nrclark/dummy_project/commit/81ebdea5df2fb42e59257cb3eaad671a5c53ca36 (by about 2-ish seconds locally).
      
      See merge request !123
      43cc7189
    • Yorick Peterse's avatar
      Mark blobs as binary whenever this is known · 3bc9611e
      Yorick Peterse authored
      Previously we would rely on Linguist::BlobHelper to determine if a blob
      was binary or not. Since Rugged knows if a blob is binary we can instead
      just inherit this information and fall back to BlobHelper if the binary
      flag wasn't set explicitly.
      
      When testing this with https://gitlab.com/nrclark/dummy_project/commit/81ebdea5df2fb42e59257cb3eaad671a5c53ca36
      it reduces loading times (locally) by around 2 seconds.
      Verified
      3bc9611e
    • Douwe Maan's avatar
      Merge branch 'better-large-diff-handling' into 'master' · 750b9e73
      Douwe Maan authored
      Improve handling of large diffs
      
      This MR adjusts the way checking for large diffs takes place. Prior to this MR the procedure was basically as follows:
      
      1. Iterate over every diff in a collection
      2. Just load the entire diff into memory, why not
      3. Check if the resulting content _including_ any diff markers/meta data exceed a threshold
      4. Prune or collapse the diff
      
      This MR changes things around so the procedure is instead as follows:
      
      1. Iterate over every diff in a collection
      2. Check if the data modified (excluding diff markers) is larger than a threshold
      3. If this is not the case, proceed as usual. if this _is_ the case we'll prune/collapse the diff
      
      See merge request !122
      750b9e73
    • Yorick Peterse's avatar
      Check for large diffs upon initialisation · 4c008a2f
      Yorick Peterse authored
      Prior to this commit the DiffCollection class was responsible for
      checking if a diff had to be collapsed or was too large to be displayed
      altogether.
      
      This commit changes both DiffCollection and Diff so that Diff itself
      checks if its too large or has to be collapsed. These checks happen when
      the Diff is being initialised. The patch size is based on the size of
      every line in every hunk of the diff, instead of relying on the diff as
      a string including diff markers.
      
      DiffCollection still has an extra check to collapse diffs when it has
      iterated over too many files. Since this is unrelated to the actual
      sizes this has been kept as-is.
      
      For binary files no pruning takes place as the diffs for these files are
      not displayed. In the past the size of a diff was reported based on the
      diff's size (including metadata). If we were to use the actual file's
      size a diff would be marked as being too large and in the case of an
      image would never be displayed.
      Unverified
      4c008a2f
  19. Sep 06, 2016
  20. Sep 05, 2016
  21. Sep 01, 2016
Loading