Resolve "Ref's interface is inconsistent with Rugged's API"
This branch is based off !130 (merged) so tests can pass successfully, so that will need to be merged first and this rebased from master afterwards. This will give a better syntax to https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/6532
Closes #30 (closed)
Merge request reports
Activity
It's probably advisable to also see if all builds pass on https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/6532 to make sure everything is ok (I harcoded a reference to this branch on the Gemfile to test it).
@eReGeBe This looks good. Can you see if the failing builds in https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/6532 are related?
I'll mark this WIP until then.
Added 2 commits:
-
0cd94c0f - 1 commit from branch
master
- c1921821 - Refactor Ref's
target
to be consistent with Rugged
-
0cd94c0f - 1 commit from branch
@DouweM the errors are not related as far as I can tell. This one:
Failure/Error: expect(too_large).to have_content('too large') expected to find text "too large" in "too_large.md 0 → 100644 View file @4842455 This diff is collapsed. Click to expand it." # ./spec/features/expand_collapse_diffs_spec.rb:61:in `block (3 levels) in <top (required)>'
I'm getting on master too. All the spinach tests failing was an issue with master. I rebased and updated gitlab-org/gitlab-ce!6532, those should be gone. I think we can tag this in the meantime.
@DouweM nevermind, I don't actually get that in master. I'll investigate further
Reassigned to @eReGeBe
Mentioned in merge request !128 (merged)
Reassigned to @DouweM
Mentioned in commit 1aab7c04