Skip to content
Snippets Groups Projects

Only create the archive file when it is done

Closed Only create the archive file when it is done
temporary_archives into master
Closed username-removed-5302 requested to merge temporary_archives into master
  1. Sep 30, 2014
    • Jacob Vosmaer's avatar
      Only create the archive file when it is done · 4d55bf51
      Jacob Vosmaer authored 
      Because GitLab caches repository archive files on disk it is important
to avoid leaving a corrupt archive when a Unicorn worker gets
interrupted. If we do not watch out for this, the next user to download
the same revision as an archive gets the unfinished file from the
interrupted worker.

This change uses a (hopefully atomic) rename to put the archive file
in its expected location.
      4d55bf51