Add a method for extracting a commit's signature

To support gitlab-org/gitlab-ce#4232

Note: This is only signature extraction, not verification.

Reassigned to @stanhu

Assigned to @stanhu for review.

Added 1 commit:

• ea42f07a - Add a method for extracting a commit's signature.

Added 28 commits:

• ea42f07a...38b190fc - 27 commits from branch gitlab-org:master
• d414e05f - Add a method for extracting a commit's signature.

Reverted the test, I'll followup with a change to gitlab-git-test that does a proper integration test.

The Rubocop failures are unrelated to this MR.

Does this need any additional work from me?

Added 74 commits:

• d414e05f...a178f66f - 73 commits from branch gitlab-org:master
• 843b14be - Add a method for extracting a commit's signature.

Thanks @kevin.oconnor7! That said, I'm not sure we're interested in merging that because we tend to use Rugged directly in the GitLab codebase instead of passing through gitlab_git these days...

/cc @DouweM

@kevin.oconnor7 gitlab_git has been absorbed into GitLab (gitlab-ce#24374, gitlab-ce!8447), so you can open a MR in GitLab CE directly. That said, I think this MR should address the full scope of gitlab-ce#20268 otherwise we'd add a method that we don't know when we'll use...

Thanks.

closed

That's fair; I have a branch where I did the full implementation just to prototype things out. I believe I only went so far as to show commits that are signed but it doesn't actually verify them. It looks like gitlab-ce#20268 doesn't require verification so it might be a good first step. I'll comment on the full scope over there.

I'll try to get that branch cleaned up this weekend and sent out.