Allow activesupport >= 4.0 and run tests on Rails 4.2 as well as Rails 5.0

Fixes #20 (closed). Required for eventual update to Rails 5.

Assignee removed

Build failure: Gem::InstallError: activesupport requires Ruby version >= 2.2.2.

@stanhu do you think we should use appraisal? It's probably overkill and we can just lock the test Gemfile, but I figured I'd ask.

@connorshea It does seem like overkill at the moment. It seems like it might be useful for CE since there are more dependencies, but I'm not sure about the overhead of maintaining that.

Added 20 commits:

• a010b80f...eb55f51a - 19 commits from branch master
• 9b1a58f8 - Allow activesupport >= 4.0

Added 40 commits:

• 9b1a58f8...d47cc16e - 39 commits from branch master
• 142b1129 - Allow activesupport >= 4.0

Added 13 commits:

• 142b1129...5870f87d - 12 commits from branch master
• 193a2579 - Allow activesupport >= 4.0

Added 9 commits:

• 193a2579...347d234d - 8 commits from branch master
• 1a346ef7 - Allow activesupport >= 4.0

Added 1 commit:

• c74e5314 - Use different Gemfiles for testing Rails 4.2 and Rails 5.0.

Added 1 commit:

• 32bbbf3a - Fix gitlab-ci.yml.

Added 1 commit:

• ea229a94 - Use anchors correctly.

Added 1 commit:

• 76a8ecd0 - Try again.

Added 1 commit:

• ed67947b - Fix gitlab-ci.yml.

Added 1 commit:

• 2526f508 - D'oh.

Added 1 commit:

• 78964c0f - Update listen version in gemspec.

Added 1 commit:

• 7c5a28ef - Loosen listen dependency.

Added 1 commit:

• afd4529e - The listen gem is very not happy.

Added 1 commit:

• 715c1a26 - Listen is installing in the wrong directory.

Added 1 commit:

• 5d994a57 - Just forget the whole vendor thing.

Added 1 commit:

• ed7d91ec - Use different Gemfiles for testing Rails 4.2 and Rails 5.0.

Added 1 commit:

• bc6fe086 - Use different Gemfiles for testing Rails 4.2 and Rails 5.0.

Changed title: Allow activesupport >= 4.0 → Allow activesupport >= 4.0 and run tests on Rails 4.2 as well as Rails 5.0

@stanhu I got tired of rebasing this every time I worked on the Rails 5 MR, so now gitlab_git is tested on Rails 4.2 as well as 5.0 and will work on either.

Should we make the default Gemfile used for Rails 4.2, and only create a separate one for Rails 5? I'm not sure I like two Gemfiles, let alone 3. :)

Added 1 commit:

• 3a44e413 - Remove rails42.gemfile, make Gemfile the Rails 4.2 gemfile.

Added 1 commit:

• 35a5f38f - Use different Gemfiles for testing Rails 4.2 and Rails 5.0.

@stanhu good point, I've updated the MR to do that instead.

Reassigned to @rspeicher

@stanhu apparently that doesn't work: https://gitlab.com/gitlab-org/gitlab_git/builds/4631731

@connorshea Ping me when this is ready.

Reassigned to @connorshea

Added 1 commit:

• 1bf6c153 - Add rails42.gemfile.

Reassigned to @rspeicher

@rspeicher it passes now, so I guess we'll have to deal with not using the Gemfile. Not really sure why that happens.

Added 12 commits:

• 1bf6c153...e9cf661b - 9 commits from branch master
• fe6c0023 - Allow activesupport >= 4.0
• c018fb26 - Use different Gemfiles for testing Rails 4.2 and Rails 5.0.
• c1c452e0 - Add rails42.gemfile.

Compare with previous version

Added 1 commit:

• ec0c9797 - Use different Gemfiles for testing Rails 4.2 and Rails 5.0.

Compare with previous version

Added 1 commit:

• eb04eda8 - Use different Gemfiles for testing Rails 4.2 and Rails 5.0.

Compare with previous version

Added 1 commit:

• 43f9f2f7 - Use different Gemfiles for testing Rails 4.2 and Rails 5.0.

Compare with previous version

@rspeicher merge before this breaks again? :)

We're not going to Rails 5 in 8.13 so this isn't exactly a priority for me right now.

@rspeicher sorry to be a bother, do you have the bandwidth now?

@connorshea Not really. Feel free to assign to another endboss.

Reassigned to @DouweM

cc: @DouweM can you review?

@connorshea Can we do something to prevent these files from getting out of date with the main Gemfile?

Reassigned to @connorshea

@DouweM I suppose we can use Appraisals

Added 10 commits:

• 43f9f2f7...18a00af5 - 7 commits from branch master
• 738fdebd - Allow activesupport >= 4.0
• 3540ca8f - Use different Gemfiles for testing Rails 4.2 and Rails 5.0.
• ecd5af8b - Update gemfiles to use Appraisals.

Compare with previous version

Added 1 commit:

• 097599e2 - Update gemfiles to use Appraisals.

Compare with previous version

Resolved all discussions

@DouweM okay, the Rails-specific gemfiles are now generated based off the Gemfile by running appraisal install.

Reassigned to @DouweM

Status changed to merged

Mentioned in commit 6b077df2