Cannot delete project when the owner doesn't exist anymore

Created by: altimore

Hello guys,

Nice project, with pretty GUI, thanks for developing this.

To reproduce the error :

Install gitlab create a project named "test" create a new admin user login as this user delete the default user try to delete the test project

error 500

Created by: tkrueger

Happened to me, too. After I added a user to the project, I could delete it without problems.

By Administrator on 2012-09-05T08:39:20 (imported from GitLab)

Created by: davispuh

still happens with newest version, basically projects without owner fails...

easiest way to reproduce:

1. create new user
2. create new project
3. edit project and set owner to user at 1. step
4. delete user

now when you'll try open: /admin/projects/{project}

ActionView::Template::Error (undefined method `name' for nil:NilClass):
    31:       %b
    32:         Owner:
    33:     %td
    34:       = @admin_project.owner.name
    35:   %tr
    36:     %td
    37:       %b
  app/views/admin/projects/show.html.haml:34:in `_app_views_admin_projects_show_html_haml__2446171807977602936_49930480'

and when trying delete:

NoMethodError (undefined method `name' for nil:NilClass):
  app/observers/system_hook_observer.rb:45:in `after_destroy'
  app/controllers/admin/projects_controller.rb:55:in `destroy'

in both cases result page is: 500 We're sorry, but something went wrong.

By Administrator on 2012-09-20T22:45:55 (imported from GitLab)

Created by: koenpunt

#1906 did fix this

@Riyad ping.

By Administrator on 2012-12-03T23:34:40 (imported from GitLab)

Created by: riyad

@koenpunt Thanks. 😄

By Administrator on 2012-12-04T12:05:03 (imported from GitLab)

Created by: sivabalan

Issue is still present in GitLab 5.0. Error 500 is thrown when trying to delete the Test project created by default admin, after admin user is deleted.

By Administrator on 2013-03-25T11:36:46 (imported from GitLab)

Created by: hoest

Even when I'm the owner of a project, I still cannot destroy/delete the project.

Started DELETE "/admin/projects/xxx" for 127.0.0.1 at 2013-04-11 13:48:07 +0200
Processing by Admin::ProjectsController#destroy as HTML
Parameters: {"authenticity_token"=>"xxx=", "id"=>"xxx"}
Completed 500 Internal Server Error in 68ms
Redis::CommandError (ERR unknown command 'exec'):
app/observers/project_observer.rb:16:in `after_destroy'
app/controllers/admin/projects_controller.rb:45:in `destroy'

By Administrator on 2013-04-11T11:51:37 (imported from GitLab)

Created by: raphendyr

Got this problem too. I fixed it with:

diff --git a/app/services/system_hooks_service.rb b/app/services/system_hooks_service.rb
index 132bb14..712285c 100644
--- a/app/services/system_hooks_service.rb
+++ b/app/services/system_hooks_service.rb
@@ -27,8 +27,8 @@ class SystemHooksService
         name: model.name,
         path: model.path,
         project_id: model.id,
-        owner_name: model.owner.name,
-        owner_email: model.owner.email
+        owner_name: model.owner ? model.owner.name : 'unknwon',
+        owner_email: model.owner ? model.owner.email : 'unknown@invalid'
       })
     when User
       data.merge!({

By Administrator on 2013-05-02T15:00:29 (imported from GitLab)

Created by: koenpunt

There probably should be a test for this, so it won't happen again?

By Administrator on 2013-05-02T22:19:21 (imported from GitLab)