Upgrade guide 2.9 to 3.0 typo

Created by: iszak

It appears that the sed command in the migration guide for 2.9 to 3.0 causes the .gitolite.rc config key to be malformed and thus breaks new repositories and possibly other side effects. As an example you can see it with

> echo '$GL_GITCONFIG_KEYS="";' | sed 's/\(GL_GITCONFIG_KEYS\s*=>*\s*\).\{2\}/"\.\*"/g'
> $".*";

The problem is the replacement pattern is missing the back reference to the group. If we change it to;

> echo '$GL_GITCONFIG_KEYS="";' | sed 's/\(GL_GITCONFIG_KEYS\s*=>*\s*\).\{2\}/\1"\.\*"/g'
> $GL_GITCONFIG_KEYS=".*";

It works as expected, so to use the same command in the wiki it should be;

sudo -u git -H sed -i "s/\(GIT_CONFIG_KEYS\s*=>*\s*\).\{2\}/\1'\.\*'/g" /home/git/.gitolite.rc

and for v2 of Gitolite

sudo -u git -H sed -i 's/\(GL_GITCONFIG_KEYS\s*=>*\s*\).\{2\}/\1"\.\*"/g' /home/git/.gitolite.rc

My apologies if this isn't the correct means for submitting a correction to the wiki.

Created by: dzaporozhets

Thank you for this issue. I'll take a look and make appropriate changes to docs

By Administrator on 2012-10-24T11:26:27 (imported from GitLab)

Created by: dzaporozhets

@SaitoWu can you take a look, please?

By Administrator on 2012-10-24T11:31:28 (imported from GitLab)

Created by: SaitoWu

sed problem?

Can u show me ur sed version?

By Administrator on 2012-10-24T11:40:35 (imported from GitLab)

Created by: iszak

My sed version is 4.2.1

By Administrator on 2012-10-24T11:45:00 (imported from GitLab)

Created by: SaitoWu

Thanks, I'll handle it.

By Administrator on 2012-10-24T11:50:32 (imported from GitLab)

Created by: SaitoWu

@iszak @randx Holy S***.

It's a github wiki page problem. the '\1' has been escaped.

The code is right. I am trying to fix it.

By Administrator on 2012-10-24T13:29:48 (imported from GitLab)

Created by: dzaporozhets

LOL.

So we have near ~ 1000 instances updated in last few days with non-working gitolite config :)

By Administrator on 2012-10-24T13:42:09 (imported from GitLab)

Created by: ivlis

Is it possible to fix gitolite config?

By Administrator on 2012-10-24T13:53:55 (imported from GitLab)

Created by: SaitoWu

@ivlis Just edit ur /home/git/.gitolite.rc file.

GIT_CONFIG_KEYS = '.*'

will fix the problem.

By Administrator on 2012-10-24T13:56:34 (imported from GitLab)

Created by: ghost

bloody hell, I was staring at this command with missing \1 for ages trying to figure out how this can work. Then I gave up with a conclusion that my brain must be ageing... (-;

By Administrator on 2012-10-24T13:58:00 (imported from GitLab)

Created by: dzaporozhets

I'm going to share it with twitter users https://gist.github.com/3946188 @SaitoWu can you take a look please

By Administrator on 2012-10-24T14:00:09 (imported from GitLab)

Created by: SaitoWu

Sorry guys, it's my fault..

By Administrator on 2012-10-24T14:01:32 (imported from GitLab)

Created by: SaitoWu

@randx gist is correct.

By Administrator on 2012-10-24T14:05:41 (imported from GitLab)

Created by: dzaporozhets

@SaitoWu thanks for help. Published to twitter. Hope users wont kill me :)

By Administrator on 2012-10-24T14:07:29 (imported from GitLab)

Created by: ghost

sure they won't. This is a trifle in comparison to what Gitlab gives

By Administrator on 2012-10-24T14:15:32 (imported from GitLab)

Created by: riyad

The gitlab:app:status task should check for this.

By Administrator on 2012-10-24T15:04:18 (imported from GitLab)