Skip to content
Snippets Groups Projects
New issue look: Off

Post receive hooks fail if /home/git/repositories is a symlink

    • Closed Issue created by Terri Chu @terrichu

    Created by: Razer6

    If home/git/repositories is a symlink all post receive hooks fail with

    gitlab:1276 on POST_RECEIVE at just now
Class
PostReceive
Arguments
"rpool/repositories/repositories/root/test13"
"0000000000000000000000000000000000000000"
"5ad1a2184774efe3e5a916e49f09540d88ebce90"
"refs/heads/master"
"admin_local_host_1356345379"
Exception
NoMethodError
Error
undefined method `id' for nil:NilClass

    gitlab:check is green. I recognized this on my production server and could reproduce it on my development VM. Running on 4.1.0pre c8ba5c2d

    Related to #2359 (closed)

    Designs

    Child items ...

    • Activity

    • Terri Chu
      Terri Chu @terrichu ·
      Author Developer

      Created by: dzaporozhets

      In your case Gitlab.config.gitolite.repos_path.to_s.should == "rpool/repositories/repositories/"

      what is your gitolite.repos_path in gitlab.yml config?

      By Administrator on 2012-12-26T13:16:58 (imported from GitLab)

    • Terri Chu
      Terri Chu @terrichu ·
      Author Developer

      Created by: Razer6

      In my gitlab.ymlrepos_paht is set to:

        repos_path: /home/git/repositories/

      Changing that to repos_path: /rpool/repositories/repositories/ and removing the the symlink cause

      root@gitlab:/home/gitlab/gitlab# sudo -u gitlab -H git clone git@localhost:gitolite-admin.git /tmp/gitolite-admin
Cloning into /tmp/gitolite-admin...
Warning: Permanently added 'localhost' (RSA) to the list of known hosts.
FATAL: R any gitolite-admin gitlab DENIED by fallthru
(or you mis-spelled the reponame)
fatal: The remote end hung up unexpectedly

      By Administrator on 2012-12-26T13:41:24 (imported from GitLab)

    • Terri Chu
      Terri Chu @terrichu ·
      Author Developer

      Created by: dzaporozhets

      git clone git@localhost:gitolite-admin without .git

      By Administrator on 2012-12-26T14:17:22 (imported from GitLab)

    • Terri Chu
      Terri Chu @terrichu ·
      Author Developer

      Created by: dzaporozhets

      changing repos_path have no influence on git clone for gitolite-admin

      By Administrator on 2012-12-26T14:18:03 (imported from GitLab)

    • Terri Chu
      Terri Chu @terrichu ·
      Author Developer

      Created by: Razer6

      Is the symlink necessary if repos_path is set to /rpool/repositories/repositories/? If the symlink is present sudo -u gitlab -H git clone git@localhost:gitolite-admin.git works. If it's not (although repos_path is set to another directory) neither sudo -u gitlab -H git clone git@localhost:gitolite-admin.git nor `sudo -u gitlab -H git clone git@localhost:gitolite-admin? is working.

      By Administrator on 2012-12-26T14:22:13 (imported from GitLab)

    • Terri Chu
      Terri Chu @terrichu ·
      Author Developer

      Created by: dzaporozhets

      you can use any symlink but you should keep a real path in repos_path. Its because we parse everything based on this variable. And if your path is rpool/repositor... we cannot extract project name with namespace without knowing about repos path rpool/repos...

      By Administrator on 2012-12-27T09:27:14 (imported from GitLab)

    • Terri Chu
      Terri Chu @terrichu ·
      Author Developer

      Created by: Razer6

      This doesn't solve the problem. Having following repository setup: /home/git/repositories is the symlink

      rschilling@rsserver:~$ sudo -u gitlab ls /home/git/repositories
daniel.karner  flyingdutchman.git  ilight.git      rschilling   sep-ex2.git  stefan.tschiggerl  testing.git  tugraz
esp-ex3.git    gitolite-admin.git  michael.grassl  sep-ex1.git  sep-ex3.git  sweb.git       trec.git
rschilling@rsserver:~$ sudo -u gitlab ls /rpool/repositories/repositories/
daniel.karner  flyingdutchman.git  ilight.git      rschilling   sep-ex2.git  stefan.tschiggerl  testing.git  tugraz
esp-ex3.git    gitolite-admin.git  michael.grassl  sep-ex1.git  sep-ex3.git  sweb.git       trec.git

      and gitlab.yml is configured to:

      ## Gitolite settings
gitolite:
  admin_uri: git@localhost:gitolite-admin
  repos_path: /rpool/repositories/repositories/
  hooks_path: /home/git/.gitolite/hooks/

      Results the behavior above. Tested on a freshly Debian VM.

      By Administrator on 2012-12-27T10:27:18 (imported from GitLab)

    • Terri Chu
      Terri Chu @terrichu ·
      Author Developer

      Created by: dzaporozhets

      Results the behavior above

      What results? Failing resque or git clone gitolite?

      By Administrator on 2012-12-27T10:34:45 (imported from GitLab)

    • Terri Chu
      Terri Chu @terrichu ·
      Author Developer

      Created by: Razer6

      sudo -u gitlab -H git clone git@localhost:gitolite-admin.git works but all retried rescue jobs still fail. Edit: Post receive hooks for new pushed commits work. Is there a possibility to get the failed hooks working again?

      By Administrator on 2012-12-27T11:03:11 (imported from GitLab)

    • Terri Chu
      Terri Chu @terrichu ·
      Author Developer

      Created by: riyad

      @razer6 maybe you need to rebuild the Gitolite config after changing the repos_path? sudo -u gitlab -H bundle exec rake gitlab:gitolite:update_repos RAILS_ENV=production

      By Administrator on 2012-12-27T16:09:23 (imported from GitLab)

    • Terri Chu
      Terri Chu @terrichu ·
      Author Developer

      Created by: Razer6

      Unfortunately no difference. Still

      NoMethodError
undefined method `id' for nil:NilClass
/home/gitlab/gitlab/app/models/project.rb:104:in `find_with_namespace'
/home/gitlab/gitlab/app/workers/post_receive.rb:9:in `perform'

      By Administrator on 2012-12-27T19:07:39 (imported from GitLab)

    • Terri Chu
      Terri Chu @terrichu ·
      Author Developer

      Created by: mcfedr

      I am having the same problem. I have changed my repos_path to the non symlinked path but still all my post receives are failing. I have tried gitlab:gitolite:update_repos - still not working. Both new and old post receives are failing.

      Would it make any difference, I have enabled namespaces, but all of my projects are in the global namespace.

      Having said that, it seems to be working again now.

      By Administrator on 2013-01-15T10:24:49 (imported from GitLab)

    • Terri Chu
      Terri Chu @terrichu ·
      Author Developer

      Created by: bytheway

      I'm having similar trouble with our post_receive hook. In my case, /home/git is symlinked to another place. I've changed the gitolite.repos_path to point to the non-symlinked path, but I'm still getting errors. Looking at the queue, it is strange that the repos path that is in the resque job is not absolute:

      usr/local/gitlab/git-home/repositories/...

      So, when the PostReceive class is run, the first thing it does is:

      repo_path.gsub!(Gitlab.config.gitolite.repos_path.to_s, "")

      Well, the job's path doesn't start with a /, but the config.gitolite.repos path DOES, so the gsub is a noop.

      This really messes with the lookup of the namespace that occurs later in that file.

      By Administrator on 2013-01-16T20:09:18 (imported from GitLab)

    • Terri Chu
      Terri Chu @terrichu ·
      Author Developer

      Created by: bytheway

      Got it! Forgot to restart the resque daemon. Everything is working now. (Hopefully this can help others that run into this issue)

      By Administrator on 2013-01-16T20:58:51 (imported from GitLab)

    • Terri Chu
      Terri Chu @terrichu ·
      Author Developer

      Created by: dzaporozhets

      also this commit helps to debug an issue next time https://github.com/gitlabhq/gitlabhq/commit/7121a58eb9e4dcb63d762e17a668f3bb4b0eaa85

      By Administrator on 2013-01-29T09:43:30 (imported from GitLab)

    Please register or sign in to reply