Commit data does not load for branch names that contain a forward slash '/'

Created by: mjdetullio

4.0 stable, production

Reproduce:

1. Push a branch with a forward slash in it, i.e "feature/example"
2. Open project in GitLab and click Files tab
3. Use dropdown to select the newly pushed branch
4. See "Loading commit data..." next to files/folders

The JSON request that is sent to retrieve the data returns a 404.

Production log shows:

Started GET "/my-namspace/my-project/feature/example/logs_tree/?_=1357598278507" for 127.0.0.1 at 2013-01-07 17:37:57 -0500
Processing by RefsController#logs_tree as JS
Parameters: {"_"=>"1357598278507", "project_id"=>"my-namespace/my-project/feature", "id"=>"example"}

The bottom line should show:

Parameters: {"_"=>"1357598278507", "project_id"=>"my-namespace/my-project", "id"=>"feature/example"}

Is there a particular file that handles the URL parsing for tree browsing that I can take a shot at? Or is there a patch available? I've done some rooting and haven't quite found what I'm looking for.

Created by: riyad

@randx we should make sure that the project id matches at most one "/".

By Administrator on 2013-01-07T23:12:00 (imported from GitLab)

Created by: mjdetullio

Be careful detecting project names with that change because it may break projects in the root namespace. For branch "feature/example" in "my-project" with no namespace it may show:

Started GET "/my-project/feature/example/logs_tree/?_=1357598278507" for 127.0.0.1 at 2013-01-07 17:37:57 -0500
Processing by RefsController#logs_tree as JS
Parameters: {"_"=>"1357598278507", "project_id"=>"my-project/feature", "id"=>"example"}

Of course I wasn't sure where the URL parsing and project name detection happens, so it could be a simple change for 0 to 1 forward slashes.

Is it all in ./spec/routing/project_routing_spec.rb?

By Administrator on 2013-01-08T00:30:45 (imported from GitLab)

Created by: hiroponz

404 error occurred, when showing non ascii paths with no namespace. The following repo contains non ascii paths("テスト.txt").

https://github.com/hiroponz/example

By Administrator on 2013-01-08T04:47:55 (imported from GitLab)

Created by: dzaporozhets

I will ffix all routing issues by adding namespace scope. The only problems is to decide what scope global projects will get.

Maybe like /0/projectname

By Administrator on 2013-01-08T07:27:56 (imported from GitLab)

Created by: dzaporozhets

Fixed by aa97ff7f

By Administrator on 2013-01-09T07:35:48 (imported from GitLab)