[feature] Parse commit message for Markdown

Created by: borisguery

It would be nice if the commit messages would be parsed for markdown to display nicely.

I usually use markdown everywhere, for example, redmine does it:

Fixed favorite & removed etag

* fixed serialization groups
* check for empty date instead of null

Looks like:

Created by: riyad

Actually it is. (see https://github.com/gitlabhq/gitlabhq/blob/master/app/views/commits/_commit_box.html.haml#L22)

By Administrator on 2013-01-09T16:20:51 (imported from GitLab)

Created by: cdbennett

@Riyad I at least as of GitLab 6.9.0, commit messages do not seem to get rendered as Markdown. There is code in _commit_box.html.haml that escapes the commit message:

.commit-box
  %h3.commit-title
    = gfm escape_once(@commit.title)
  - if @commit.description.present?
    %pre.commit-description
      = gfm escape_once(@commit.description)

but this issue requests that the commit message be rendered with actual Markdown formatting applied.

Perhaps we need to add a project-specific option like "Parse commit messages as Markdown". Which would remove the "escape_once", possibly that would be enough to get actual Markdown rendering?

By Administrator on 2014-06-05T20:02:16 (imported from GitLab)

Created by: cdbennett

I see that this commit actually removed the Markdown parsing and replaced it with just escaping the raw content:

commit 496f88afe10f95a7aa64ea8ab10e57412f827283
Author: Robert Speicher <rspeicher@gmail.com>
Date:   Wed Sep 19 19:42:26 2012 -0400

    Escape text passed to gfm by link_to_gfm

diff --git a/app/views/commits/_commit_box.html.haml b/app/views/commits/_commit_box.html.haml
index 506f4e0..572337d 100644
--- a/app/views/commits/_commit_box.html.haml
+++ b/app/views/commits/_commit_box.html.haml
@@ -11,10 +11,10 @@
       = link_to tree_project_ref_path(@project, @commit.id), class: "browse-button primary grouped" do
         %strong Browse Code »
     %h3.commit-title.page_title
-      = gfm @commit.title
+      = gfm escape_once(@commit.title)
     - if @commit.description.present?
       %pre.commit-description
-        = gfm @commit.description
+        = gfm escape_once(@commit.description)
   .commit-info
     .row
       .span4

Also, why was the parsing of issue references in commit messages removed? It looks like there was a nice feature where issue numbers like #FOO-3345 would be turned into links. I see #2293 indicates that GFM Markdown parser itself creates issue links from that pattern, so maybe if the commit messages is once again parsed as GFM we'll have the issue links back.

By Administrator on 2014-06-05T20:27:48 (imported from GitLab)